I get an error but could not find it, please help
Hi guys,
I get an error, want to sort names but i could not solve the problem.
Please help me.
Program code
Code:#include <stdio.h>#include <stdlib.h> #include <string.h> int main(void) { char *name[5]; char *temp; int i, j; for(i=0;i<5;i++) { printf("%d. name enter:",i+1);scanf("%s", &name[i]); } for (i=0;i<5;i++){ for (j=0;j<4;j++) { if (strcmp(*name[j],*name[j+1])>0) { temp=name[j]; name[j]=name[j+1]; name[j+1]=temp; } } } for(i=0;i<5;i++) puts(*name[i]); getch(); return (0); }
What is this program supposed to do?
Look up a C++ Reference and learn How To Ask Questions The Smart WayOriginally Posted by Bjarne Stroustrup (2000-10-14)
it is can't sort name, gives error
what is the correct spelling ?
Well, here's the problem:
the above declares an array of 5 pointers to char. Great, but that means that there is no space allocated for the names. To keep it simple, I would recommend something like:Code:char *name[5];
This way, you at least can store names of up to a length of 99.Code:char name[5][100];
Next, this is wrong:
Combined with my previous suggestion, you would write:Code:scanf("%s", &name[i]);
Your sort implementation looks suspect too. Your compiler may be warning you; pay attention to the warnings. Note that you cannot assign to arrays, so you might use strcpy instead.Code:scanf("%99s", name[i]);
Look up a C++ Reference and learn How To Ask Questions The Smart Way
Thank you very much, but when two parameterized for loop error, please can you run ?
Here is error
Code:for(i=0;i<5;i++) { for (j=0;j<4;j++) { if (strcmp(*name[j],*name[j+1])>0) { temp=name[j]; name[j]=name[j+1]; name[j+1]=temp; } } }
Last edited by miralay; 12-12-2015 at 12:35 PM.
Refer to the last sentence of my previous post.
Look up a C++ Reference and learn How To Ask Questions The Smart Way
dev c++ ide error mesage is windows has stopped working.
I've read, but I couldn't.
Your strcmp call is wrong because the arguments are characters, but strcmp expects strings, or rather pointers to the first characters of strings.
Your swap implementation is wrong once you change to use an array of arrays because arrays cannot be assigned. I already suggested strcpy as part of an alternative.
Look up a C++ Reference and learn How To Ask Questions The Smart Way
anyway, thanks a lot. I'll do it repeat
