Thread: segmentation fault (core dumped) error!

segmentation fault (core dumped) comes when i compile the below code:

Code:

#include<stdio.h>  
void main(void){      

       FILE *fp1,*fp2;     
       fp1=fopen("file1","r"); 
       fp2=fopen("file2","w");     
       char ch;     

       while((ch=fgetc(fp1))!=EOF){         
              fputc(ch,fp2);     
       } 
}

Originally Posted by Seyed Basim

segmentation fault (core dumped) comes when i compile the below code:

Code:

#include<stdio.h>  
void main(void){      

       FILE *fp1,*fp2;     
       fp1=fopen("file1","r"); 
       fp2=fopen("file2","w");     
       char ch;     

       while((ch=fgetc(fp1))!=EOF){         
              fputc(ch,fp2);     
       } 
}

main() should be defined to return an int.

Code:

int main(void) { ... }

When fixed, the code compiles fine. You don't get a seg fault on compile, but you would when you run the code if "file1" does not exist.

Thank you, it works now (Y)

To add, you always need to check the return value from any of the buffered I/O functions, especially the open, read, and write functions. That would have shown up the missing file when trying to open a non-existent file.

Also, fgetc() returns an int, so your variable "ch" should be an int too.