my function doesn't work! it should work

this is just part of my program the problem are when the program asks user to put code if the user puts nothing just press enter. the program should go to ShowData() and show all records in Manufacterer.txt in A : drive but it doesn't show all of record inside that file
the second problem is variable calls 'position' . it works as an index so if there are 5 records in Manufacterer.txt when the user puts the new record. the position should be 5. it uses fread doesn't it? but i don't know how to find the last position in the file.

sorry i am very new with C
thanks very much for helping

Code:

---

#include <stdio.h>
//#include<conio.h>
#include<string.h>
#include<stdlib.h>
#include <math.h>

void ShowData();
        struct Manufacturer //creating your own data type
        {
                char code[6],name[16], address[21],contact[11];//63 type long
                int position;
                bool pass;
        };
  main(void)
{
        long offset;
        int test;
        struct Manufacturer m;
        m.pass=true;
FILE *f;
        f=fopen("a:\\Manufacturer.txt","ab");//"w" c

        puts("Enter code:");
        gets(m.code);
        fflush(stdin);
        printf("%d",test);
        while (strlen(m.code)>0)
        {
 
               
                        puts("Enter name:");
                        gets(m.name);
                       
                        puts("Enter Address: ");
                        gets(m.address);
                       
               
                        puts("Enter contact");
                        gets(m.contact);
                        m.position;
                        fwrite(&m, sizeof(m),1,f);
                       
         
                  puts("Enter code");
                  gets(m.code);
                  m.position=m.position+1;
         
}
        ;
fclose(f);

ShowData();
}
        void ShowData()
        {
        struct Manufacturer ma;
        int count = 1;
        FILE *f;

       
        f=fopen("a:\\Manufacturer.txt","r+");
               
                while (fread(&ma,sizeof(ma),1,f)==1)
        {
                printf("Show");
                printf("Record %d\n",count++);
                puts(ma.code);
                puts(ma.name);
                puts(ma.address);
                puts(ma.contact);
                puts(ma.position);
                printf("inside");
        }
        fclose(f);
        }

---

Quote:

---

Originally posted by Shadow

You don't need the semi-colon after ShowData() nor the semi-colon after the closing brace.

---

You need the semi-colon after ShowData(); because it's a function prototype. And you need a semi-colon after the closing brance because it's the closing brance of the struct.

Quote:

---

You need the semi-colon after ShowData(); because it's a function prototype. And you need a semi-colon after the closing brance because it's the closing brance of the struct.

---

You know what? You're right. Woopsy:D It's early...

- edit -
I said fooey on it. It just goes to show ya what sloppy code will do to a person.

i was in a hurry to post it but after i made it look more tidy and ran the program it still doesn't work!
can anyone tell me what 's wrong with my program
Thanks

Code:

---

#include <stdio.h>
//#include<conio.h>
#include<string.h>
#include<stdlib.h>
#include <math.h>
//********* prototype******//
void ShowData();
        struct Manufacturer //creating your own data type
        {
                char code[6],name[16], address[21],contact[11];//63 type long
                int position;
                bool pass;
        };
//*********main********//       
  main(void)
{
        long offset;
        int test;
        struct Manufacturer m;
        m.pass=true;
        FILE *f;
        f=fopen("a:\\Manufacturer.txt","ab");//"w" c

        puts("Enter code:");
        gets(m.code);
        fflush(stdin);
        printf("%d",test);
        while (strlen(m.code)>0)
        {
                        puts("Enter name:");
                        gets(m.name);
                        puts("Enter Address: ");
                        gets(m.address);
                        puts("Enter contact");
                        gets(m.contact);
                        m.position;
                        fwrite(&m, sizeof(m),1,f);
                        puts("Enter code");
                  gets(m.code);
                  m.position=m.position+1;
  }
        fclose(f);
        ShowData();
}

//*******function************//
        void ShowData()
        {
        struct Manufacturer ma;
        int count = 1;
        FILE *f;

        f=fopen("a:\\Manufacturer.txt","r+");
               
                while (fread(&ma,sizeof(ma),1,f)==1)
                {
                printf("Show");
                printf("Record %d\n",count++);
                puts(ma.code);
                puts(ma.name);
                puts(ma.address);
                puts(ma.contact);
                puts(ma.position);
                printf("inside");
                }
        fclose(f);
}

---

Remove m.position; in your while loop and initialize m.position.

Code:

---

long offset;
int test;
struct Manufacturer m;
m.pass=true;
FILE *f;
m.position = 0;

---

Use printf to print an integer:

Code:

---

printf("%d\n", ma.position);

---

Try this:

Code:

---



#include <stdio.h>
#include<conio.h>
#include<string.h>
#include<stdlib.h>
#include <math.h>
//********* prototype******//
void ShowData();
bool isEmpty( char *str );

        struct Manufacturer //creating your own data type
        {
                char code[6],name[16], address[21],contact[11];//63 type long
                int position;
                bool pass;
        };
//*********main********//       
  int main(void)
{
#define UNDEFINED 12345


                int test = UNDEFINED; //...hmmm...unused...
        long offsettest = UNDEFINED; //  ...unused...
        int increment = 0;
        struct Manufacturer m;
                FILE *f = fopen("a:\\Manufacturer.txt","wb");//no such "ab", see below...
fseek(f, 0, SEEK_END); ///...to append...

        printf("%d",test);

while (isEmpty(m.code) == false)
{
memset(m, 0, sizeof(struct Manufacturer) ); //...initialize all to zero...

                        puts("Enter name:");
                        gets(m.name);
                        puts("Enter Address: ");
                        gets(m.address);
                        puts("Enter contact");
                        gets(m.contact);               
                        puts("Enter code");
                                  gets(m.code);
                                  m.position = ++increment;
                                                m.pass=true;

                                                fwrite(&m, sizeof(m),1,f);
  }
        fclose(f);
        ShowData();
}

//*******function************//
        void ShowData()
        {
        struct Manufacturer ma;
        int count = 1;
        FILE *f;

        f=fopen("a:\\Manufacturer.txt","rb");
               
                while (fread(&ma,sizeof(ma),1,f)==1)
                {
                printf("Show");
                printf("Record %d\n",count++);
                puts(ma.code);
                puts(ma.name);
                puts(ma.address);
                puts(ma.contact);
                printf("%i", ma.position); //..."puts" is for strings only...
                printf("inside");
                                getch();
                }
        fclose(f);
}




bool isEmpty( char *str ){

int len = strlen(str);
int i = 0;

while(i < len)
 {
  if( !isspace(str[i]) && str[i] != '\n' )
  return false;

 i++;
 }

return true;
}

---

Two comments

1. This is very bad
gets(m.code);
fflush(stdin);

gets offers no protection against buffer overflow, and fflush(stdin) is undefined (it might work for you, but it will not work for me).

Search the board for endless discussions

2. bool pass;
Now you're writing C++
There is no bool type in C

Note: Salem thinks C++ is the Devils Language...

All too many people can't tell the difference

>There is no bool type in C
In C99 there is a bool type, but for the time being it's best to conform to C89 until the new standard becomes more widespread.

>Note: Salem thinks C++ is the Devils Language...
Well, seeing as how so many people think C++ and C are the same thing...

-Prelude

Is it bool or BOOL?..I know in VC6.0/mfc I use BOOL to get it to work but what does the standard say?

BOOL is a typedef for an int. Depending on your compiler, it will occupy either 2 or 4 bytes of memory. On the other hand, the C++ bool uses a single bit. I think :)

BTW: who says C++ is not C?

include <stdbool.h> is missing in the source code!

>Is it bool or BOOL?..I know in VC6.0/mfc I use BOOL to get it to
>work but what does the standard say?
BOOL is a typedef declared in windows.h, it's not standard.

>BTW: who says C++ is not C?
Um...everyone who knows what they're talking about.

-Prelude