I want to check whether a certain character is in a string or not
but my code is not working
Code:#include<stdio.h> #include<string.h> int main() { char ch[200]; char c; int n,i; puts("Enter string"); scanf("%s",ch); puts("ENTER Character"); scanf("%c",&c); for(i=0;ch[i]!='\0';i++) { if(ch[i]==c); puts("found"); } return 0; }
> if(ch[i]==c);
Watch the ; at the end of this line.
If you dance barefoot on the broken glass of undefined behaviour, you've got to expect the occasional cut.
If at first you don't succeed, try writing your phone number on the exam paper.
Now it is running without entering a character
Try putting a space before the %c in the second scanf(), this will tell scanf() to skip leading white space characters.
Jim
Well know it is working but could you elaborate your answer,I am not understanding it perfectly
Salem and jimblumberg have addressed critical problems in your code in their posts #2 and #4 respectively, but to add:
- You should not use "%s" as the format specifier when reading a string with scanf. The reason is that this allows the user to enter a longer string than can be stored in the corresponding array. Rather, since the array has 200 chars, you should set a field width one less than this (one element is reserved for the null character), i.e., "%199s".
- Unless you are required to write the loop, or it is otherwise convenient/efficient to use your own loop, you should make use of existing library components, e.g., use strchr from <string.h>.
As for why jimblumberg's suggestion works: when you enter the string, the newline left from entering the input is left in the input buffer. This is then read by scanf with %c. Adding a leading space consumes that newline instead, hence allowing you to read the desired character.
Look up a C++ Reference and learn How To Ask Questions The Smart WayOriginally Posted by Bjarne Stroustrup (2000-10-14)
still not getting it
Maybe the FAQ would be more clear?
FAQ > How do I avoid a "dangling" newline when reading single character user input? - Cprogramming.com
