Thread: Im confused why this isnt working

Code:

main()
{
    UserOutput(-1);
    GetALine();
    UserOutput(7);
    UserOutput(-2);
}
int UserOutput(int action)
{
  if(action==-1)
  {
      printf("Hello How are you doing today");
      return 0;


  }
  else if(action==-2)
  {
      printf("Good bye see you soon");
      return 0;
  }
  else if (action>0)
  {
    GetALine(action);
  }
}


  int GetALine(char str[])
{
  int i=0;


    while(str[i]!='\n')
   {
        i++;
   }


    return i;
}

It works for the first part of my program than after it finishes the first useroutput nothing else works please explain it too me im confused I thought it should work my computer says error program stopped working

also you pass a integer to the function GetAline when it expects a char array.

Did you place the function prototypes above or is this the exact same code you compile?

In addition, you're also calling "GetALine()" in your "UserOutput()" function and passing an integer instead of a char[].

And why does a function called "GetALine()" seem to be counting the length of a string (with the assumption that it terminates with a newline instead of '\0')? Based on the name, I would assume that function is supposed to get a line of text.

This is the code I compiled The first function is main the second is useroutput which displays welcome and good bye messages as well as getting the length of the user output.

no it doesnt get a line of text it gets the user input and counts the length of that

A development process

Start small. Get one function working correctly (compiled and tested). Then add the next one. Build up gradually, testing along the way.

Originally Posted by lavaboy

no it doesnt get a line of text it gets the user input and counts the length of that

It doesn't get any user input in that function.

Does main() require a return(0);

Originally Posted by lavaboy

This is the code I compiled The first function is main the second is useroutput which displays welcome and good bye messages as well as getting the length of the user output.

try reading this link