getword

I did this function for get a word from a file until reaching EOF.
I can compile it without error message, but when I try to run it, it looks to take longtime. I think my loop has problem, who can help me to work out?

here is the code:

#include <ctype.h>
#include <stdio.h>
#include <string.h>

char *getword(FILE *fp)
{
char ch;
char *w, *word;
char buf[BUFSIZ];
w = buf;
ch = fgetc(fp);
while( isspace(ch))
;
if(ch != EOF)
*w++ = ch;
*w = '\0';
word = strdup(w);
return word;
}

>while( isspace(ch))
>;
If ch is whitespace then this is an infinite loop, it will never end because you never get another character. A better way would be:

Code:

ch = fgetc(fp); 
while(isspace(ch)) 
  ch = fgetc(fp);

Or to remove the redundant calls, you can simply initialize ch to a non-whitespace value and only get a new character from the file inside the loop.

The second problem is that you only assign one character to the buffer, this should be a loop that gets another character and tests it for both whitespace and EOF. Your ch variable should also be int because EOF is a value that cannot be held by a char.

-Prelude