Thread: Beginners question:

Okay, so my assignment for my C class is to generate a program that will allow the user to enter data for a stock and calculate the amount of stocks that ended up being positive, negative, and neutral.

I tried to do this using one stock, here is my code;

#define _CRT_SECURE_NO_WARNINGS
#include <iostream>
#include <stdio.h>
#include <math.h>
#include <stdlib.h>

Code:

void main()
{




    float Neg;
    float incst;
    float shrs;
    float bpps;
    float crnt;
    float crntcst;
    float yrfes;
    float pft;
    float tpft;




    printf("IMB number of shares:");
    scanf("%f", &shrs);
    printf("IBM buying price per share: ");
    scanf("%f", &bpps);
    printf("IBM current price per share: ");
    scanf("%f", &crnt);
    printf("IBM yearly Fee: ");
    scanf("%f", &yrfes);






    incst = shrs*bpps;
    crntcst = shrs*crnt;
    pft = crntcst - incst - yrfes;
    tpft = pft;
    


    printf("The initial cost is %0.2f\n", incst);
    printf("The Current cost is %0.2f\n", crntcst);
    printf("The profit is %0.2f\n", pft);
    if (pft < 0 )
    {
        int Sum;
        int Neg;
        Sum = 0;
        int add;
        add = 1;
        
        Neg=Sum -= add;
        printf("given stock is negative");
        






    }
    
    else if (pft > 1)
    {
        printf("given stock is positive");
        


    }
    else if (pft == 0)
    {
        printf("given stock did not change");
        
    }


    printf("the negatives were %d", Neg);
    
    system("pause");
}

Where does it hurt?

Code:

printf("IMB number of shares:");

I'm sure it's supposed to be

Code:

printf("IBM number of shares:");

To whomever gave you the advice to use system("pause"), here is my middle finger.

seeing i use (and program for) mostly win systems, i still use system();

and yes i know the risks....same as back in the xp days of renaming cmd.exe to login.scr!

i miss that trick!

which as a side note, what would work instead of system("cls");

Sure, there are potential risks with using system(), but sometimes you just need to call other programs in your code for the sake of making your program simpler. Fortunately what's in your user's PATH is their problem, not yours, and so long as you can make it easy for them to change the execution string, calling external programs from your program can be a pretty useful thing to do.

With that said, this isn't a situation where it's a good choice. My advice would be to either write your program so that it works well with standard streams (and forget the concept of terminals entirely), use a library that's designed for terminals like curses, or use a prettier, graphical interface instead.