Thread: "Overprinted"?

Hi guys, it's me again!

And of course, I've got a problem.

I promised I will do the next program starting with a small program, but now I need to solve this:

When I print the following text, the string does not appear.

Code:

 void atacant(Personatge *personatge, Enemic *aux, int *nMort, int nDaus, int *nFinal){ //nFinal indica si el enemic ha mort.


     int nMal = 0;
     nDaus = rand() %20; //Tira daus


     if (nDaus == 1){ //Falla
         printf("%s ataca i... (%d) falla!\n",personatge->strNom, nDaus);
         fflush(stdout);
         printf("Vida de %s es: %d\n",aux->strNom, aux->nVida);
         fflush(stdout);
     }
     if(nDaus >= 2 && nDaus <= 19){ //Normal
         printf("%s ataca i... (%d) Atac normal.\n",personatge->strNom, nDaus);
         nMal = personatge->nAtac - aux->nDefensa;
         fflush(stdout);
         printf("Fa %d de mal a %s\n", nMal, aux->strNom);
         aux->nVida = aux->nVida - nMal;
         if(aux->nVida <= 0){
             printf("%s ha mort!\n", aux->strNom);
             *nFinal = 1;
         }
         else{
             printf("Vida de %s es: %d\n",aux->strNom, aux->nVida);
         }
     }
     if(nDaus == 20){ //Critic
         printf("%s ataca i... (%d) Atac critic!\n", personatge->strNom, nDaus);
         nMal = personatge->nAtac *2 - aux->nDefensa;
         fflush(stdout);
         printf("Fa %d de mal a %s\n", nMal, aux->strNom);
         aux->nVida = aux->nVida - nMal;
         if(aux->nVida <= 0){
             fflush(stdout);
             printf("%s ha mort!\n");
             *nFinal = 1;
         }
         else{
             printf("Vida de %s es: %d\n", aux->strNom, aux->nVida);
         }
     }


 }

That's what appear:

What is the string that is NOT being printed, and what line number is the code that should print it?

Please be specific!

Originally Posted by stahta01

Explain in your own words what you think this line does.

Code:

nDaus = rand() %20; //Tira daus

Your code implies that you do NOT know what it really does.

What is the possible range of values you expect to be placed in nDaus?

Tim S.

That line gives a range of values between 1 and 20 to the variable nDaus. It's like a dice for the game, where 1 means a failed attack, 2-19 normal attack and 20 critical attack.

Originally Posted by Adak

What is the string that is NOT being printed, and what line number is the code that should print it?

Please be specific!

My fault, sorry.

Code:

void atacant(Personatge *personatge, Enemic *aux, int *nMort, int nDaus, int *nFinal){ //nFinal indica si el enemic ha mort.


     int nMal = 0;
     nDaus = rand() %20; //nDaus recives a value between 1-20


     if (nDaus == 1){ //If nDaus = 1 --> Attack failed.
         printf("%s ataca i... (%d) falla!\n",personatge->strNom, nDaus); //That string does not appear.
         fflush(stdout);
         printf("Vida de %s es: %d\n",aux->strNom, aux->nVida);
         fflush(stdout);
     }
     if(nDaus >= 2 && nDaus <= 19){ //Normal attack
         printf("%s ataca i... (%d) Atac normal.\n",personatge->strNom, nDaus); //That string does not appear.
         nMal = personatge->nAtac - aux->nDefensa;
         fflush(stdout);
         printf("Fa %d de mal a %s\n", nMal, aux->strNom);
         aux->nVida = aux->nVida - nMal;
         if(aux->nVida <= 0){
             printf("%s ha mort!\n", aux->strNom);
             *nFinal = 1;
         }
         else{
             printf("Vida de %s es: %d\n",aux->strNom, aux->nVida);
         }
     }
     if(nDaus == 20){ //Critical attack
         printf("%s ataca i... (%d) Atac critic!\n", personatge->strNom, nDaus); //That string does not appear.
         nMal = personatge->nAtac *2 - aux->nDefensa;
         fflush(stdout);
        printf("Fa %d de mal a %s\n", nMal, aux->strNom);
         aux->nVida = aux->nVida - nMal;
         if(aux->nVida <= 0){
             fflush(stdout);
             printf("%s ha mort!\n");
             *nFinal = 1;
         }
         else{
             printf("Vida de %s es: %d\n", aux->strNom, aux->nVida);
         }
     }


 }

Originally Posted by stahta01

False, that line of code gives a range of values from 0 to 19.

Tim S.

True, thanks.

But this is not the problem, the problem is that some strings don't appear.

Can someone help me, please?

Add a line 4 to atacant(). Print out all the values of the parameters that are being brought into atacant, and then add a scanf("%d", &garbage) with a "garbage" variable you will add to atacant. I want you to verify that atacant() is getting the right values. The values that you are expecting, and then a pause so you can see them.

Then line 5, change % 21 to rand() % 20 + 1. I believe the range you want is 1 to 20, not 0 to 19, correct?

Every time you run the program, unless you are seeding the random generator first, you will be given the SAME random values by rand(). This is for testing purposes. Print out on line 6, WHAT that value of nDaus is, by printing it out, just like you did for line #4. Tell us what that value is for nDaus.


Lastly, are you getting any warnings when you compile the program? If so, what are they?

Hi Adak, thank you for your help. Here is all the information that you want:

WARNINGS: (Are not in english, so I have to translate)

main's type return is not int

I think that's because I'm using VOID MAIN instead of INT MAIN.

There's no more warnings.

Now, I've done that to see the variables that are being brought into atacant:

Code:

 
 printf(" %s %d %d %d %d\n", personatge->strNom, personatge->nAtac, personatge->nVida, personatge->nExperiencia, personatge->nNivell);
 printf(" %s %d %d %d %d\n", aux->strNom, aux->nAtac, aux->nDefensa, aux->nExperiencia);
 printf("%d\n",*(*nMort));
 printf("%d\n",*nFinal);

And that's waht I see:



All the numbers are correct, BUT the second string has the same problem that I said in the other post.

nDaus has a diferent value every time, that's what I need. I put this on the main.c:

Code:

srand(time(NULL));

What do you think?

Originally Posted by Salem

> What do you think?
I think that none of the code you've posted (or the input you've suggested) has either of the strings "Proba" or "vall" present.
So it's impossible to say where they're coming from.

> printf("%s ha mort!\n", aux->strNom); //HERE THE %S IS PRINTED BUT UNDER THE REST OF THE TEXT: "ha mort!\n"
If strNom contains a newline, then this is what you will see?
Did you by chance read the line with fgets(), which will store the \n.

> printf("%s ha mort!\n");
> printf(" %s %d %d %d %d\n", aux->strNom, aux->nAtac, aux->nDefensa, aux->nExperiencia);
As a matter of urgency, you must start compiling with the -Wall option, and fixing ALL the warnings before trying to run code.
If you don't supply the correct number (and type) of parameters to printf/scanf, then all sorts of crap can happen.

If you don't understand a particular warning, then ask (don't ignore it).

Too few parameters in the presence of a %s is one sure way of getting large amounts of garbage printed (assuming it doesn't crash in the process).

Sorry Salem, but I don't know how to use the -Wall option

Originally Posted by Adak

Correct! main() should return an int to the operating system.



OK, leave srand() there.

You have to follow this variable (aux->strNom) back to it's origin, and when you find it, post the code. It has an newline at the end of it, that needs to be removed, right at the point it's being given a value.

As Salem suggested, it's probably because it was given it's value by fgets(), since fgets() puts a newline onto the end of a string.
Do you know how to delete a last newline char from a string yet?

Well, here is the code where the variable aux->strNom is:

Code:

 void lluita(Personatge *personatge, Cua *cua, int *nMort, int *nExpguany,Enemic *enemics){
 
      Enemic aux; //HERE IT'S THE VARIABLE aux.
      int nDaus = 0, nFinal = 0,  nVidamax = 0; 
 
 
      if(cua->cap == cua->ult){
          printf("Error, cua buida!\n");
      }
      else{
 
          nVidamax = personatge->nVida;
          while((*cua).cap != (*cua).ult && *nMort != 1){
              aux = CUA_primer(*cua); //The variable aux recieves information from CUA, that in english is a TAIL.
              CUA_desencua(&(*cua));
              personatge->nVida = nVidamax;
              nFinal = 0;
              printf("Combat entre %s i %s\n", personatge->strNom, aux.strNom);
              printf("Prem una tecla per continuar...\n");
             getchar();
            fflush(stdout);
 
              while(nFinal == 0){
 
                  atacant(personatge, &aux, &nMort, nDaus, &nFinal);
                  if(nFinal == 0){
                      enemic(personatge, &aux, &nMort, nDaus, &nFinal);
                  }


                  if(nFinal == 1 ){
 
                  printf("ENTRA EN IF nFinal = 1\n");
                      if( *nMort == 0){ 
                         printf("BIEN, SE ACTUALIZA LA EXPERIENCIA\n");
                         *nExpguany = *nExpguany +  enemics->nExperiencia;
                         printf("%d\n",*nExpguany);
                         printf("Final del combat!\n");
                     }
                     else{
                         printf("NO EXP!!\n");
                         printf("Final del combat!\n");
                    }

And of course, I'm going to put the code where the info comes from, but before that, let me explain what's in the tail.

There are the different enemies available and their own characteristics, like attack, defense and experience.

How I get that? I get that info from a FILE .txt

Here is the code:

Code:

 void carregaEnemics(FILE *f, Enemic **enemics, int *nEnemic){
 
  char strNombre[50];
  char strNom[50];
  char cSalt;
  int nAtac = 0, nDefensa = 0, nVida = 0, nExperiencia = 0, i;
 
      fscanf(f,"%d",nEnemic); //Reads how many enemies are in the file.
      fgets(strNombre,50,f);
      *enemics = (Enemic*)malloc(sizeof(Enemic) * *nEnemic);
      if(enemics == NULL){
          printf("Error!\n");
      }
      else{
          for( i = 0; i < *nEnemic; i++){
 
              fgets(strNombre,50,f); //Reading the name.
              strNombre[strlen(strNombre)-1]='\0'; //Remove the \n
 
              fscanf(f,"%d",&nAtac);
              fscanf(f,"%d",&nDefensa);
              fscanf(f,"%d",&nVida);
              fscanf(f,"%d",&nExperiencia);
 
 
              strcpy((*enemics)[i].strNom, strNombre);
              (*enemics)[i].nAtac = nAtac;
              (*enemics)[i].nDefensa = nDefensa;
              (*enemics)[i].nVida = nVida;
              (*enemics)[i].nExperiencia = nExperiencia;
              fgets(strNombre,50,f);
          }
      }
 
 
  }

The file is like:

11
Cavaller
20
10
100
100
Tirant lo Blanc
120
75
600
1100
Sarrai a cavall
70
35
350
500
Creuat
30
15
150
200
Sarrai amb espasa i escut
40
20
200
300
Creuat delit
100
65
500
900
Pirata marroqui
50
25
250
400
Inquisidor
90
60
450
800
Joanot Martorell
240
150
1200
3000
Carmesina
130
80
650
1200
Guia estil
150
100
50
4500

-Number of enemies
-Name
-Attack
-Defense
-Life
-Experience





Hope this will help you, guys!