Thread: expected warning?

My current project is a basic syntax to c/c++ translator.
In legacy code that I inherited this line


LINE INPUT hFile,a$


Is translated to:

Code:

fgets(a, 1048576, hFile);

with a$ having the default size of a $:

Code:

char a[2048];

I am curious why no (windows) compiler(gcc,PellesC) emits a warning when compiling?


Is it a "JUST DON'T DO THAT !!" ?




James

Code:

#include <stdio.h>

int main() {
    char a[2048];
    fgets(a, 1048576, stdin);
    puts(a);
    return 0;
}

No warning for that, even with -Wall -Wextra. In general, it would be hard to provide one considering that a could be dynamically allocated.

If a's a char array, it may be best to use:

Code:

    fgets(a, sizeof(a), stdin);

although if a's a pointer, that won't work.
In that case, you have to keep track of the size.