Thread: Need help with C program that count words, lines and characters

My C program doesn't seem to be working correctly, output is completely off . Basically the program is suppose to output amount of characters, amount of word and amount of newlines that have been typed. Multiple consecutive spaces should not be counted as multiple words. Any ideas?

Code:

#include <stdio.h>

void main ()


{
	char c=0;
	
	int num_words=0, num_chars=0, num_newlines=0;


	while ((c=getchar()) !=4);


			num_chars++;
			printf("Number of Characters: %d",num_chars);
			
		if (num_chars==10)//ASCII code of space


		{
			num_words++;
			printf("Number of words: %d",num_words);
		}
		else (num_chars==32);
		{
			num_newlines++;
			printf("Number of newlines: %d",num_newlines);
		}
}

I tried that. it still doesn't work.

here is my new code

Code:

 #include <stdio.h>

int main (void)


{
	char c=0;
	
	int num_words=0, num_chars=0, num_newlines=0;


	while ((c=getchar()) !=4 && c!=EOF);
	{


			num_chars++;
			printf("Number of Characters: %d\n",num_chars);
			
		if (num_chars==10)//ASCII code of space


		{
			num_words++;
			printf("Number of words: %d\n",num_words);
		}
		else (num_chars==32);
		{
			num_newlines++;
			printf("Number of newlines: %d\n",num_newlines);
		}
	}
		return 0;
}

First if you want to test c for EOF then it must be an int not a char.

Second, please explain what you think is happening in the following line:

Code:

while ((c=getchar()) !=4 && c!=EOF);

Also this line?

Code:

        if (num_chars==10)//ASCII code of space

First the decimal value for space is 32 not 10. Plus why are you trying to compare num_chars to a space? You really should stop using the magic numbers 10, 32 and use their character representations '\n' = new line and just use a space inside single quotes for the space character.

Jim

Second, please explain what you think is happening in the following line:
Basically it's a while loop reading keys from the keyboard by using function getchar(). The reading of characters from keyboard will be stopped when ^D is typed which has ASCII value 4. I think EOF indicates the end of input. Do you think I should remove it?

Code:

while ((c=getchar()) !=4 && c!=EOF);

Also this line?
Yes it should be 32 not 10 for space. and it should be 10 for new line. Basically I am writing a cprogram that ask for input. The output of this program should be amount of characters, amount of works and amount of new lines.

Code:

        if (num_chars==10)//ASCII code of space

First the decimal value for space is 32 not 10. Plus why are you trying to compare num_chars to a space? You really should stop using the magic numbers 10, 32 and use their character representations '\n' = new line and just use a space inside single quotes for the space character.

here is my new code. It still doesn't count character/words/new line correctly

Code:

#include <stdio.h>

int main (void)


{
	int c=0;
	
	int num_words=0, num_chars=0, num_newlines=0;


	while ((c=getchar()) !=EOF);
	{


			num_chars++;
			printf("Number of Characters: %d\n",num_chars);
			
		if (num_chars==' ')


		{
			num_words++;
			printf("Number of words: %d\n",num_words);
		}
		else (num_chars=='\n');
		{
			num_newlines++;
			printf("Number of newlines: %d\n",num_newlines);
		}
	}
		return 0;
}

Tried that but still it doesn't seem to work correctly. Here the new code

Code:

 #include <stdio.h>

int main (void)


{
    int c=0;
    
    int num_words=0, num_chars=0, num_newlines=0;


    while ((c=getchar()) !=EOF);
    {


            num_chars++;
            printf("Number of Characters: %d\n",num_chars);
            
        if (c==' ')


        {
            num_words++;
            printf("Number of words: %d\n",num_words);
        }
        else (num_chars=='\n');
        {
            num_newlines++;
            printf("Number of newlines: %d\n",num_newlines);
        }
    }
        return 0;
}

Originally Posted by Zach786

Tried that but still it doesn't seem to work correctly.

I do believe that.. What does your compiler tell ?
Kurt

Code:

while ((c=getchar()) !=EOF);

For a start you should eventually correct the error std10093 pointed out 18 hours ago.

Bye, Andreas

[QUOTE=AndiPersti;1165792][CODE]
while ((c=getchar()) !=EOF);
So I have removed the semicolon. I can't remove the semicolon from else statement as laserlight suggested. I am getting compiler error. Here is new code

Code:

 #include <stdio.h>

int main (void)


{
    int c=0;
    
    int num_words=0, num_chars=0, num_newlines=0;


    while ((c=getchar()) !=EOF)
    {


            num_chars++;
            printf("Number of Characters: %d\n",num_chars);
            
        if (c==' ')


        {
            num_words++;
            printf("Number of words: %d\n",num_words);
        }
        else (c=='\n');
        {


                num_newlines++;
            printf("Number of newlines: %d\n",num_newlines);
        }
    }
        return 0;
}

Output:

when I run the program. It works correctly for characters. how can i change the program so it counts the character and lines correctly? any help would greatly appreciate. Sorry if I am not seeing something obvious .