Thread: A function error, Please help

my getstring function is messing up if it's used after the program accepts an integer value


the program does this :

enter name 1 : mike
enter name 2 : john
enter age 1 : 7
enter name 3 : //after age 1 is entered name 3 is skipped and the program asks for age 2
enter age 2 : 8

Code:

#include <stdio.h>


void getstring(char str[]){
     
     int state = 1;
     int x = 0;
     char ch;
     
     while( (ch=getchar()) != '\n' )
     {
            if( ch == ' ' || ch == '\t' )
            {
                if(state == 0)
                {
                         str[x++]= ch;
                         state = 1;
                }
            }
            else
            {
                str[x++]= ch;
                state = 0;
            }
     }
     str[x] = '\0';
     return ;
}




int main(void){
    
    int x,y;
    char name[50];
    char name2[50];
    char name3[50];
    
    printf("Enter name 1: ");
    getstring(name);
    printf("Enter name 2: ");
    getstring(name2);
    printf("\nEnter age 1: ");
    scanf("%d",&x);
    printf("\nEnter name 3: ");
    getstring(name3);
    printf("\nEnter age  2: ");
    scanf("%d",&y);
    getchar();
    return 0;
}

positive criticism as well as solutions would be much appreciated

Also, thanks to Whiteflags and Grumpy for helping me with my last error.

When you used scanf() to retrieve the number the end of line character was left in the input buffer, which is causing your problems. You need to clear the input buffer before you try to get your character input.

Is there a reason you're not using the fgets() function to retrieve data instead of making your own?

Jim

i created my own because trying to input data into a structure using fgets was problematic

There's this return value called EOF that you're supposed to check.

Code:

#include <ctype.h>
#include <stdio.h>

int skipblank(FILE *iop)
{
    int c;

    while ((c = getc(iop)) != EOF && isblank(c))
        ;
    return c;
}

int getline(char *s, size_t n, FILE *iop)
{
    char *endp = s + n - 1;
    int c;

    for (c = skipblank(iop); c != EOF && c != '\n'; c = getc(iop))
        if (s < endp)
            *s++ = c;
    *s = '\0';
    return c;
}

If you're going to strip out the whitespace from the end as well, you'd probably benefit from making your input function as simple as possible then simply making a copy of the string without the whitespace and stuff. It just seems like a more straightforward process.