building a function

**tosihiro2007** · 03-15-2013

Code:

flag = 1;
while(flag == 1)
{
    printf("What is the student's Assignment 1 mark? :");
    scanf("%d",&a1);


    if(a1>100||a1<0)
{
    printf("Invalid mark. Please enter again\n");
    flag = 1;
}
else
{
        flag = 0;
}
}


flag = 1;
while(flag == 1)
{
    printf("What is the student's Assignment 2 mark? :");
    scanf("%d",&a2);


    if(a2>100||a2<0)
{
    printf("Invalid mark. Please enter again\n");
    flag = 1;
}
else
{
        flag = 0;
}
}


flag = 1;
while(flag == 1)
{


    printf("What is the student's Assignment 3 mark? :");
    scanf("%d",&a3);


    if(a3>100||a3<0)
{
    printf("Invalid mark. Please enter again\n");
    flag = 1;
}
else
{
        flag = 0;
}
}

I'm trying to find a way to express this thing into a function because it's repeating almost same thing over and over again.
Could anyone give me any suggestions?

**tosihiro2007** · 03-15-2013

nvm i got it

**Adak** · 03-15-2013

Good instincts, Toshiro. When code has to be repeated over and over in a program, it's time to re-do it.

**rogster001** · 03-15-2013

You could try something like:

Code:

# define MAXGRADES 3
	
//...

	void ShowNextGrade(int thisGrade)
	{
		int gradeVal = 101;
        int flag = 1;

		if(thisGrade == 0)
		{
			printf("What is the student's Assignment 1 mark? :");
		}
		//else if...etc
		
		while(flag == 1)
		{
			scanf("%d",&gradeVal);

			if( gradeVal > 100 || gradeVal < 0 ) 
			{
				printf("Invalid mark. Please enter again\n");
			}
			else
			{
				flag = 0;
			}

		}
	}

	//...

	int gradeNum = 0;

	while(gradeNum < MAXGRADES)
	{	
		ShowNextGrade(gradeNum);
		gradeNum++;
	}

Thread: building a function

Thread Tools

Search Thread

Display

building a function

Similar Threads

help with building

Problem with my building function for my roguelike

building a DLL

building/using dll's

building pc..