help with this code please

[tost]

hello,
this code give me the same output not OH

#include<stdio.h>

int main(){

char arr[100];
int i;
int judge=0;
printf("please input ");
scanf("%c",&arr);

for(i=0;i<100;i++){

    if((arr[i]== 'o'|| arr[i]=='O')&&(arr[i+1]=='h' ||arr[i+1]=='H'))
        judge++;

}

if(judge>0)
    printf("OH");
else
    printf("not OH");

return 0;

}

[Tclausex]

How can arr[i] be 'o' or 'O' AND 'h' or 'H' at the same time?

[Matticus]

Check your warnings:

main.c||In function 'main':|
main.c|9|warning: format '%c' expects type 'char *', but argument 2 has type 'char (*)[100]'|
||=== Build finished: 0 errors, 1 warnings ===|

If you're trying to read a string with "scanf()", you need to make it:

scanf("%s",arr);

--------

if((arr[i]== 'o'|| arr[i]=='O')&&(arr[i]=='h' ||arr[i]=='H'))

Check your logic. A character cannot be 'O' and 'H' at the same time.

[tost]

How can arr[i] be 'o' or 'O' AND 'h' or 'H' at the same time?

yes i edited the code after i post it ,you posted too fast

[tost]

Check your warnings:

main.c||In function 'main':|
main.c|9|warning: format '%c' expects type 'char *', but argument 2 has type 'char (*)[100]'|
||=== Build finished: 0 errors, 1 warnings ===|

If you're trying to read a string with "scanf()", you need to make it:

scanf("%s",arr);

--------

if((arr[i]== 'o'|| arr[i]=='O')&&(arr[i]=='h' ||arr[i]=='H'))

Check your logic. A character cannot be 'O' and 'H' at the same time.

that's right this is an array i edited the code

#include<stdio.h>

 

int main(){
 
char arr[100];
int i;
int judge=0;
printf("please input ");
scanf("%s",arr);

 
for(i=0;i<100;i++){
 
    if((arr[i]== 'o'|| arr[i]=='O')&&(arr[i+1]=='h' ||arr[i+1]=='H'))
        judge++;
 
}
 
if(judge>0)
    printf("OH");
else
    printf("not OH");
 
return 0;
 
}

[Matticus]

for(i=0;i<100;i++){

    if((arr[i]== 'o'|| arr[i]=='O')&&(arr[i+1]=='h' ||arr[i+1]=='H'))
        judge++;

}

Be careful - you're overrunning the bounds of your array here (i+1)

[tost]

for(i=0;i<100;i++){

    if((arr[i]== 'o'|| arr[i]=='O')&&(arr[i+1]=='h' ||arr[i+1]=='H'))
        judge++;

}

Be careful - you're overrunning the bounds of your array here (i+1)

i changed the code

#include<stdio.h>

int main(){

char arr[100],OH[]={'O','o','H','h'};
int i,x=0;
printf("please input ");
scanf("%s",arr);

for(i = 0; i<100; i++){
            int judge = 0;
            int j;
            for(j = 0; j < 3; j++)
                if(arr[i] == OH[j])
                   judge = 1;
                if(judge){
                        x++;
                   continue;}
}
if(x>0)
    printf("OH");
else
    printf("not OH");

return 0;


}

output OH with any input

[Matticus]

Was this to change the functionality? To fix the overrun, you only had to:

for(i=0;i<99;i++)

P.S. It's good practice to avoid "magic numbers" - consider using something like this instead of the fixed value of 100:

#define MAX_LEN 100

[tost]

i changed the code to avid overrun and you said better solution and more easy
[CODE]

#include<stdio.h>

int main(){
int const MAX_LEN =100;
char arr[MAX_LEN];
int i;
int judge=0;
printf("please input ");
scanf("%s",arr);


for(i=0;i<99;i++){

    if((arr[i]== 'o'|| arr[i]=='O')&&(arr[i+1]=='h' ||arr[i+1]=='H'))
        judge++;

}

if(judge>0)
    printf("OH");
else
    printf("not OH");

return 0;

}

thank you it is working

could you check this topic here
when it is better to use define and constant ??
i checked the topic and i think it is better to use define for the thing that i will use alot in code

constant will take place in memory
define will just replace

so what you think sir ?

[Matticus]

I'd recommend that you use "#define" for now.

[tost]

ok thank you for help