Hi,i need help with my book database.I use scanf to store book name,author name and year when is book writen.
example:
I have problem when i want to printf all books from database with this:Code:scanf(" %[^\n]",k[i].bookname);
Output:Code:for(i=0;i<counter;i++){ fscanf(f,"%s %s %d",k[i].bookname,k[i].author,&k[i].year); printf("\n%d\t%s\t%s\t%d",(i+1),k[i].bookname,k[i].author,k[i].year);}
Number Book name Author name Year
1 King John 0
2 William Shakespeare 1590
How can i fix this?
Show more code. Particularly, all the code that loops through and stores the data into the structure and all variables/declarations related to said structure.
Next, describe the input you've given to produce the above output and how it differs from what you expected when output.
Right now you've given us some code and output and simply said "its wrong how do I fix it?" We can guess that the book name not showing up is a problem but without more of the scanning code and what specific input you entered we are hindered.
"Owners of dogs will have noticed that, if you provide them with food and water and shelter and affection, they will think you are god. Whereas owners of cats are compelled to realize that, if you provide them with food and water and shelter and affection, they draw the conclusion that they are gods."
-Christopher Hitchens
My code is in Croatian...
I type full book name with spaces in bookname,name and surname of author in author,and year in year with this:
and when i open file it look like this:Code:printf("\nHow many books do you want to type in?\n"); scanf("%d",&n); for(i=0;i<n;i++){ fseek(f,0,SEEK_END); printf("\nWrite in the name of %d. book:\n",i+1); scanf(" %[^\n]",k[i].bookname); printf("\nWrite in the name of %d. author:\n",i+1); scanf(" %[^\n]",k[i].author); printf("\nWrite the year of %d. book:\n",i+1); scanf("%d",&k[i].year); fprintf(f,"%s %s %d\n",k[i].bookname,k[i].author,k[i].year);}
King John William Shakespeare 1590
Rome and Juliett William Shakespeare 1600
but when i want to printf all books from file with this code:
I get output like thisCode:for(i=0;i<counter;i++){ fscanf(f,"%s %s %d",k[i].bookname,k[i].author,&k[i].year); printf("\n%d\t%s\t%s\t%d",(i+1),k[i].bookname,k[i].author,k[i].year);}
Number Book name Author name Year
1 King John 0
2 William Shakespeare 1590
> King John William Shakespeare 1590
> Rome and Juliett William Shakespeare 1600
How is the vanilla %s supposed to tell the difference between the space between "King" and "John" as being part of the title, and the space between "John" and "William" as separating the title from the author.
> scanf(" %[^\n]",k[i].bookname);
You already recognise that %s breaks at spaces, so you do this.
> fprintf(f,"%s %s %d\n",k[i].bookname,k[i].author,k[i].year);
Then you introduce more spaces making the whole file confusing.
You need to make your file unambiguous, say perhaps
fprintf(f,"%s\n%s\n%d\n",k[i].bookname,k[i].author,k[i].year);
where you can use the same style scanf calls you used to read from stdin to begin with.
Or say
fprintf(f,"%s,%s,%d\n",k[i].bookname,k[i].author,k[i].year);
fprintf(f,"%s\t%s\t%d\n",k[i].bookname,k[i].author,k[i].year);
where you introduce some kind of separator which doesn't appear in your input data.
If you dance barefoot on the broken glass of undefined behaviour, you've got to expect the occasional cut.
If at first you don't succeed, try writing your phone number on the exam paper.
Oh so stupid mistake,didnt think about that .. Thank you!
