Trying to sort 3 numbers from lowest to highest, but I get weird answer

[blackendstars]

#include <stdio.h>
int main (void)
{
  int a, b, c, low, med, high;
   printf("***SORT THE  NUMBER***\n");
  // ask user for a, b, c
    printf(" Enter a:\n ");
     scanf("%d", &a);
      printf(" Enter b:\n");
       scanf("%d", &b);
      printf(" Enter c:\n");
     scanf("%d", &c);
a = high;
b = med;
c = low;
if (a<c<b)
b = high;
c = med;
a = low;
if (c<a<b)
c = low;
a = med;
b = high;

c = high;
b = low;
a = med;
printf("the sorted numbers are %d, %d, %d\n", a, b, c);
return 0;
}

when i compile it, and input the values, like a=4 b 5 c=2
i get 134514169, -1218548731, -1217273868

how do I make the out put as (2 4 5) ?
what am i doing wrong?

[Click_here]

The values of a,b,c are lost when you say "a=high", "b=med" and "c=low"

It should be "high=a"...

a<c<b should be a<c&&c<b - you can't do 2 comparisons at the same time.

[Click_here]

Also, you need to use curly braces with your "if" statement, or else only the next line is conditionally executed by the statement

[blackendstars]

Okay so I changed the coding to this

 #include <stdio.h>
int main (void)
{
  int a, b, c, low, med, high;
   printf("***SORT THE  NUMBER***\n");
  // ask user for a, b, c
    printf(" Enter a:\n ");
     scanf("%d", &a);
      printf(" Enter b:\n");
       scanf("%d", &b);
      printf(" Enter c:\n");
     scanf("%d", &c);
high = a;
med = b;
low = c;
if (a<c&&c<b)
{high = b;
med = c;
low = a;}
if (c<a&&a<b)
{low = c;
med = a;
high = b;}
if (b<a&&a<c)
{high = c;
low = b;
med = a;}
printf("the sorted numbers are %d, %d, %d\n", a, b, c);
return 0;
}

and whatever number I put for a, b, c, it doesn't sort them

[laserlight]

You need to format your code properly with good indentation, e.g.,

#include <stdio.h>

int main(void)
{
    int a, b, c, low, med, high;
    printf("***SORT THE  NUMBER***\n");

    // ask user for a, b, c
    printf(" Enter a:\n ");
    scanf("%d", &a);
    printf(" Enter b:\n");
    scanf("%d", &b);
    printf(" Enter c:\n");
    scanf("%d", &c);

    high = a;
    med = b;
    low = c;
    if (a < c && c < b)
    {
        high = b;
        med = c;
        low = a;
    }
    if (c < a && a < b)
    {
        low = c;
        med = a;
        high = b;
    }
    if (b < a && a < c)
    {
        high = c;
        low = b;
        med = a;
    }
    printf("the sorted numbers are %d, %d, %d\n", a, b, c);
    return 0;
}

Anyway, I notice that at the end, you print a, b and c, rather than high, med and low. Also, I believe that there are 6 ways by which 3 numbers can be ordered, but you only cater to 4.

[camel-man]

printf("the sorted numbers are %d, %d, %d\n", high, med, low);

[blackendstars]

printf("the sorted numbers are %d, %d, %d\n", high, med, low);

yea, it's the same. I tried that before and it didn't work.
I'm very confused why it's not working

[camel-man]

Take into account what Laserlight has said, she points out that you are only accounting for 4 of the 6 cases of ordering.

[blackendstars]

You need to format your code properly with good indentation, e.g.,

#include <stdio.h>

int main(void)
{
    int a, b, c, low, med, high;
    printf("***SORT THE  NUMBER***\n");

    // ask user for a, b, c
    printf(" Enter a:\n ");
    scanf("%d", &a);
    printf(" Enter b:\n");
    scanf("%d", &b);
    printf(" Enter c:\n");
    scanf("%d", &c);

    high = a;
    med = b;
    low = c;
    if (a < c && c < b)
    {
        high = b;
        med = c;
        low = a;
    }
    if (c < a && a < b)
    {
        low = c;
        med = a;
        high = b;
    }
    if (b < a && a < c)
    {
        high = c;
        low = b;
        med = a;
    }
    printf("the sorted numbers are %d, %d, %d\n", a, b, c);
    return 0;
}

Anyway, I notice that at the end, you print a, b and c, rather than high, med and low. Also, I believe that there are 6 ways by which 3 numbers can be ordered, but you only cater to 4.

Wow thanks...I couldn't have done it without the help from you guys

[Click_here]

In other words, consider all these possibilities

a<b<c
a<c<b
b<a<c
b<c<a
c<a<b
c<b<a

Your code doesn't account for all these.

[edit]
Replied too slow: good to see you got it.
[/edit]

[Tanu]

You are not checking all the possible conditions...

• a<b<c
• a<c<b
• b<a<c
• b<c<a
• c<a<b
• c<b<a

& i'd suggest using nested ifs...
[edit]
I was even slower...
[/edit]