Thread: strcpy get errors

Originally Posted by Barney McGrew

I suppose you have a different interpretation of the word 'use' then. For me it's 'wherever gets is called', perhaps 'use' might imply 'used for a useful purpose' for you. I dunno.

Well .... an English-language dictionary I have at hand defines

use n. act of putting to a purpose: state or fact of being put to a purpose : advantageous use to which anything may be applied: the fact of serving a purpose: the profit or profitable purpose derived from property: convenience : employment : need : advantage : usefulness.

For you, the word "use" does not imply a purpose or usefulness, but my dictionary disagrees with you.

Code:

#include <stdio.h>

int main(void) { puts(""); }

This program does not use puts.

EDIT: If you think that statement's true, ask around and see how many people agree with you before you explain the ambiguity of the term 'use'.

EDIT#2: Sorry. Forgot that puts emits a new line with an empty string.

Code:

#include <stdio.h>

int main(void) { fputs("", stdout); }

There we go.

Those programs call puts() and fputs() respectively. They don't call them for any particular purpose (other than, perhaps, your purpose of flogging a dead horse).

Originally Posted by Click_here

Strcpy is your best bet with a definition for the maximum string length.

and strcpy is the best bet for making a single pointer to copy many array, am i right?

Originally Posted by c99tutorial

Wow. fgets requires 3 parameters and gets requires 1. Is typing two more parameters really that much extra work?

hahaha, when i read this i began to laugh much funny say bro,

Originally Posted by c99tutorial

Code:

#define GETS(buf) do { \
     _Static_assert(sizeof buf > sizeof(void*), "GETS(buf): character array required"); \
    fgets(buf, sizeof(buf), stdin); \
     if (buf[strlen(buf)-1] == '\n') buf[strlen(buf)-1] = '\0'; \
} while(0)

why u using strlen when u define a gets, i didnt quite understand?

Originally Posted by Barney McGrew

gets is only as unsafe as strcpy is, in that it will mess up if it's used incorrectly.

lol so strcpy is bad as gets?
Then why both of the command is written if it isnt used?
Its like a trap command for programmer, lol

Originally Posted by nonpuz

I was referring to the C11 draft, _NOT_ the microsoft garbage.

whats ur meaning of microsoft garbage?

Originally Posted by esbo

but gets(string) is pretty easy to remember and simple to use.

lol, gets are using

Code:

gets(&string);

see the &
is that the programmer forgot to add this,
and the suck things are error to compile
and must re-check the code again, like scanf for reading variables

if gets didnt useful, useless being, crap,
why the c developer making gets() if it isnt for used?

thats what all i want to say for the long debating

i am newbie to C
i know i didnt know a lot, i confused at some quote but i laugh too for some quote :P
but i had to learn the basic C code to advanced C code, so if i messing up with gets, puts or other else, it still a lesson.
It didnt destroy my pc though LoL and i can still fixed the code.
Soon, if gets() didnt good i will use fgets() if i making a program or vice versa,
by the way this thread get one thousand audience lol, great!!!

if gets didnt useful, useless being, crap, why the c developer making gets() if it isnt for used?
thats what all i want to say for the long debating

gets is from simpler times (think 60s and 70s) when security issues weren't really a huge concern. Only after it was exploited time and again did the lightbulb come on and gets was officially deprecated as well as unofficially discouraged by everyone with any claim to proficiency in C. gets survived up until the most recent standard (C11) for simple fear of breaking existing code. The short answer is just because something exists doesn't mean it's a good idea. There could be legitimate historical reasons that keep a bad idea from the death it deserves.

Originally Posted by loserone+_+

why u using strlen when u define a gets, i didnt quite understand?

gets will produce a string without the newline at the end of the string after it reads it. So if you want to emulate gets by using fgets, you must remove the newline from the end if it is present. The following will remove the newline from the end of str if it is present:

Code:

if (str[strlen(str)-1] == '\n') str[strlen(str)-1] = '\0';

Originally Posted by c99tutorial

The following will remove the newline from the end of str if it is present:

Code:

if (str[strlen(str)-1] == '\n') str[strlen(str)-1] = '\0';

strchr would do the job better:

Code:

char *p = strchr(str, '\n');
if (p)
{
    *p = '\0';
}

However, Nominal Animal has convinced me that strcspn is more elegant and hardly less efficient:

Code:

str[strcspn(str, "\n")] = '\0';

or if you're paranoid about the '\r' despite the fgets call:

Code:

str[strcspn(str, "\r\n")] = '\0';

However, Nominal Animal has convinced me that strcspn is more elegant and hardly less efficient:

Well, it is less efficient, and provably so. But since strcspn is my favored solution for removing a newline after fgets, I'd argue that it's silly to optimize the newline removal given that the cost of fgets (being I/O bound) will vastly overwhelm just about any subsequent attempts to sanitize the string.