Segmentation fault? Strings

This program compares two strings and outputs however many times the letter is found in the word the user inputs. I'm having a problem with it getting a segmentation fault and can't figure out why? Am I somehow performing a buffer overflow with this code?

Code:

#include <stdio.h>
#include <string.h>

int num_appearances(char word[], char letter);


int main()
{ 
    char wordstring[20];
    char searchLetter;
    
    printf("Please enter the word you would like to scan:\n");
    scanf("%s", &wordstring);
    
    printf("Please enter a letter to search for:\n");
    scanf("%s", &searchLetter);
    
    int num_times = num_appearances(wordstring, searchLetter);
    
    if(num_times > 0){
                 printf("The letter %s appears %d times in the word %s\n", searchLetter, num_times, wordstring);
    }
    else
        printf("The letter %s appeared zero times in your word\n");                                        
    system("PAUSE");
    return 0;
    
}


int num_appearances(char word[], char letter){
    int i;
    int counter = 0;
    for(i=0; i != '\0'; i++){
             if(strcmp(&word[i], &letter)==0){
                        counter++;
             }
             else
                 continue;      
    }
    
    return counter;
}

> scanf("%s", &searchLetter);
Yes, this is always a buffer overflow.

If you want to read the next non-space letter, then use
scanf(" %c", &searchLetter);

More train-wrecks here

Code:

    for(i=0; i != '\0'; i++){
             if(strcmp(&word[i], &letter)==0){

I suggest you think about it, rather than just throwing in some & all over the place to shut the compiler up.

Thanks thats what I love about programming. You learn something new everyday. I'll fix this pronto, but If I'm trying to compare two string characters doesn't the strcmp() function require you to pass by reference? Thats why I passed word[i] and letter that way. Thanks again

strcmp() is for comparing two strings, but in your for-loop I think you want to compare two characters. For comparing two characters you just use the "==" operator.

Bye, Andreas

Ok Thanks I appreciate that.