Text based frame in win32 console

Hi!

I have a huge problem with drawing my frame in win32 console. At the coordinates (79,24) I have to draw a LEFTUP part of the frame (I hope you understand what i mean). My code draws the LEFTUP part but after it draws it program jumps into the new line and everything is moved.

This is my frame:

Code:

RIGHTDOWN part->(|-)-------------------------------------(-|)<- LEFTDOWN part
                 |                                         |
                 |                                         |
                 |                                         |
                 |                                         |
                 |                                         |
                 |                                         |
                 |                                         |
RIGHTUP part->  (|-)-------------------------------------(-|)<- LEFTUP part

And here's my code:

Code:

// constants for drawing a frame
# define RIGHTDOWN      218
# define RIGHTUP     192
# define LEFTDOWN       191
# define LEFTUP     217
# define HORIZONTAL     196
# define VERTICAL    179
# define VERTICALRIGHT 195
# define VERTICALLEFT  180

void Frame ()
{
	int i = 0, j = 0, k = 0, l = 0, x, y, length, height;

	x = 0;
	y = 0;
	length = 80;
	height  = 25;
	// drawing a frame
	gotoxy (x, y);
	printf ("%c", RIGHTDOWN); 
	for (i = 0; i < length-2; i++)
	{
		gotoxy (x+1+i, y);
		printf ("%c", HORIZONTAL);
		if (i == length-3)
		{
			gotoxy (x+length, y);
			printf ("%c", LEFTDOWN);
			for (j = 0; j < height-2; j++)
			{
				gotoxy (x, y+1+j);
				if (j == 0)
				{
					printf ("%c", VERTICAL);
					for (l = 0; l < length-2; l++) // drawing spaces
					{
						printf (" ");
					}
					printf ("%c", VERTICAL);
				}
				if (j == 1) // drawing title line
				{	
					printf ("%c", VERTICALRIGHT);
					for (k = 0; k < length-2; k++)
					{
						printf ("%c", HORIZONTAL);
					}
					printf ("%c", VERTICALLEFT);
				}
				else // drawing other parts of the frame
				{
					if (j != 0)
					{
						printf ("%c", VERTICAL);
						for (l = 0; l < length-2; l++) // drawing spaces
						{
							printf (" ");
						}
						printf ("%c", VERTICAL);
					}
				}
			}
			gotoxy (x, y+height);
			printf ("%c", RIGHTUP);
			for (j = 0; j < length-2; j++)
			{
				gotoxy (x+1+j, y+height);
				printf ("%c", HORIZONTAL);
			}
		}
	}
	gotoxy (length-1, height-1);
	printf ("%c", LEFTUP);
}

I complied your Frame function and it draws the frame like so:

Code:

|                        |
|------------------------|
|                        |
|                        |
|                        |
|                        |
|                        |
|------------------------|

The 2 sides stick out at the top is this the problem?

No.
Change this

Code:

gotoxy (length-1, height-1);
printf ("%c", LEFTUP);

to

Code:

gotoxy (length-1, height-2);
printf ("%c", LEFTUP);

and you'll se what do i mean.

>> My code draws the LEFTUP part but after it draws it program jumps into the new line and everything is moved.

If your screen width is 80 then when you print the 80'th character a newline is automatically performed.
I changed your width to 79 and used newlines instead of gotoxy and it works, just change it to suit your needs

Code:

#include <stdio.h>
#include <conio.h>
 
# define RIGHTDOWN     218
# define RIGHTUP       192
# define LEFTDOWN      191
# define LEFTUP        217
# define HORIZONTAL    196
# define VERTICAL      179
# define VERTICALRIGHT 195
# define VERTICALLEFT  180

#define HEIGHT 25
#define LENGTH 79

void Frame( void );

int main( void )
{
	Frame();
	getch();

	return 0;
}

void Frame( void )
{
	int loop1, loop2;

	putchar( RIGHTDOWN );
	for( loop1 = 0; loop1 < ( LENGTH - 2 ); loop1 ++ )
		putchar( HORIZONTAL );
	putchar( LEFTDOWN );

	putchar( '\n' );
	putchar( VERTICAL );
	for( loop1 = 0; loop1 < ( LENGTH - 2 ); loop1++ )
		putchar( ' ' );
	putchar( VERTICAL );

	putchar( '\n' );
	putchar( VERTICALRIGHT );
	for( loop1 = 0; loop1 < ( LENGTH - 2 ); loop1++ )
		putchar( HORIZONTAL );
	putchar( VERTICALLEFT );

	for( loop1 = 0; loop1 < ( HEIGHT - 4 ); loop1++ )
	{
		putchar( '\n' );
		putchar( VERTICAL );
		for( loop2 = 0; loop2 < ( LENGTH - 2 ); loop2++ )
			putchar( ' ' );
		putchar( VERTICAL );
	}

	putchar( '\n' );
	putchar( RIGHTUP );
	for( loop1 = 0; loop1 < ( LENGTH - 2 ); loop1++ )
		putchar( HORIZONTAL );
	putchar( LEFTUP );

}

using the newlines instead of gotoxy means the table is always left justified and starts from the coords 0,0, try changing HEIGHT & LENGTH. You shuold be able to change it to use gotoxy easy enough.

That's not good. You draw only to width = 78. I need to draw to width = 79. Is there any way to get rid of that new line?

>> You draw only to width = 78
Anymore than that and you get the automatic newlines, I don't know how to stop that. If you must have a 79 width then I suggest you enlarge your console to accomodate it.

I give up. I can't get rid off of that extra character. Now my frame is only drawed to width = 78. Drawing a frame with my code is very slow. Is there any other way to write the code for drawing a frame?

Don't know what frame you exactly need, but try these fillconsoleoutputcharacter and fillconsoleoutputattribute, at least you can make a frame, changing the background.

Unregistered

Try my code for the frame and you'll see.