Thread: fgets not truncating text

Personally, I would initialise read_ok to 0 and return_val to NULL, even though they are correctly given initial values within the loop body. prompt should be a const char*. I would prefer strchr to strstr here. (Nominal Animal's strcspn idea does not fit quite as well into your current logic, methinks.) Oh, and all those extra blank lines make me

Originally Posted by laserlight

Personally, I would initialise read_ok to 0 and return_val to NULL, even though they are correctly given initial values within the loop body. prompt should be a const char*. I would prefer strchr to strstr here. (Nominal Animal's strcspn idea does not fit quite as well into your current logic, methinks.) Oh, and all those extra blank lines make me

Initialising is always a good idea.

strchr is a better idea

const char * is a better idea

I don't know where you are seeing Nominal Animal's suggestion, though...

The extra blank lines are from a A-Style indentation program -> I'm fairly sure that I'm not a fan of it either...

Here is one that the whole family can enjoy...

Code:

char *get_user_input (const char *prompt, char *input_string, size_t input_string_size);


int main(void)
{
    char *fname;


    if ((fname = malloc(MAXNAME * sizeof(*fname))) == NULL)
    {
        fprintf(stderr, "-ERROR-\nAllocation Failure\n");
        return EXIT_FAILURE;
    }


    if (get_user_input ("Enter first name", fname, MAXNAME) != NULL)
    {
        printf("Name is %s\n", fname);
    }
    else
    {
        fprintf(stderr, "-ERROR-\nProblem with reading string\n");
        return EXIT_FAILURE;
    }


    free(fname);


    return EXIT_SUCCESS;
}


char *get_user_input (const char *prompt, char *input_string, size_t input_string_size)
{
    int read_ok = 0;
    char *return_val = NULL;


    if (prompt == NULL || input_string == NULL || input_string_size <= 0)
    {
        return NULL;
    }


    do
    {
        char *s;


        printf("%s: ", prompt);
        fflush(stdout);


        if ((return_val = fgets(input_string, input_string_size, stdin)) == NULL)
        {
            break;
        }


        if ((s = strchr(input_string, '\n')) != NULL)
        {
            *s = '\0';
            read_ok = 1;
        }
        else
        {
            int c;
            while((c = getchar()) != '\n' && c != EOF)
            {
                continue;
            }


            fprintf(stderr, "Problem with string size\n");
            read_ok = 0;
        }
    }
    while (read_ok == 0);


    return return_val;
}

Originally Posted by Click_here

I don't know where you are seeing Nominal Animal's suggestion, though...

In a different thread, which you may have seen since you've been around long enough.

Originally Posted by laserlight

In a different thread, which you may have seen since you've been around long enough.

I think I found what you were talking about here - Scanning new line - I remember it now; how can I forget this classic by soma

[Edit]
*sigh*


Removed the wrong portion of the post.


I have no idea what was written here. Sorry.
[/Edit]

Nominal Animal's code is a very neat way of removing new line characters. However, you are right in saying that it would not fit my example, as the problem I tried to solve is whether a new line has been included in the input from fgets