problem in deletion in binary search tree

[ashutosh124]

I wrote a function to delete a node in the binary search tree. The code works well in case of node having no child but fails when the node has one or two child.

void deleteNode(bstree **rootref,int delnum)
{
    bstree *temp,*parent,*succ;
    if(search(*rootref,delnum)==0)
    printf("Deletion denied, entered number not in the tree\n");
    temp=*rootref;
    while(temp&&((temp->data)!=delnum))
    {
            parent=temp;
            if(temp->data<delnum) temp=temp->right;
            else temp=temp->left;
    }
    if(!temp) printf("the element not present,deletion denied\n");
    if(!(temp->left)&&!(temp->right))
    {
        if(parent->left==temp) parent->left=NULL;
        else parent->right=NULL;
    }
    else if((temp->left)&&!(temp->right))
    {
        if(parent->left=temp) parent->left=temp->left;
        else parent->right=temp->left;
    }
    else if((temp->right)&&!(temp->left))
       {
           if(parent->left=temp) parent->left=temp->right;
           else parent->right=temp->right;
       }
    else
       {
           succ=temp->right;
           while(succ->left) succ=succ->left;
           temp->data=succ->data;
           temp=succ;
       }
       free(temp);


 }

[Salem]

> if(parent->left=temp) parent->left=temp->left;
> if(parent->left=temp) parent->left=temp->right;
This has been mentioned elsewhere in your other threads.
You're mixing up = and ==

Which compiler are you using?

A better compiler would warn you of such mistakes.

$ gcc -c -Wall foo.c
foo.c:30:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses]
foo.c:35:12: warning: suggest parentheses around assignment used as truth value [-Wparentheses]

[Shyam Raj]

I wrote a BST program recently which seems to work fine. Its here: Need help with BST Program

Salem, if you could verify the delete operation in my program.

Thanks.