Reversing a string using stack

After compiling the program, it doesn't show any errors or warnings. When the output screen loads, it asks for the input but doesn't show the output and program automatically closes. Any idea why?

Code:

#include<stdio.h>
#include<conio.h>
void push(char);
void pop();
int top=0;
char stack[10],info;
void main()
{
int i;
char str[10];
clrscr();
printf("Enter a string: ");
gets(str);
for(i=0;str[i]!='\0';i++) {
    info=str[i];
    push(info);
  }
pop();
getch();
}
void push(char info)
{
stack[top]=info;
top++;
}
void pop()
{
while(stack[top]!=NULL) {
    printf("%c",stack[top]);
    top--;
   }
}

It does not make sense for 'pop' to pop all items off. Just as 'push' only adds one item, 'pop' should only remove one item.

As for the bug, stack[top] is where the next item will be pushed to, but in 'pop' you want to start looking at the one below there.
However, you should also note that there is no NULL in your stack, so the while loop is broken anyway. You need another way of checking if the stack has anything in it or not. Perhaps you could use 'top'.

You should also change your main to:

Code:

int main(void)

, and never use 'gets'. 'gets' is widely known to be fundamentally broken, and cannot be fixed. You need to use 'fgets' instead.

Originally Posted by iMalc

It does not make sense for 'pop' to pop all items off. Just as 'push' only adds one item, 'pop' should only remove one item.

As for the bug, stack[top] is where the next item will be pushed to, but in 'pop' you want to start looking at the one below there.
However, you should also note that there is no NULL in your stack, so the while loop is broken anyway. You need another way of checking if the stack has anything in it or not. Perhaps you could use 'top'.

I will fix the gets and void main points ASAP.
I have used the while loop in the pop function to ensure that ALL the elements of stack get popped :O...or am i going about it the wrong way?

What if i edit the pop() function like this-

Code:

void pop()
{
top--;
while(stack[top]!=NULL) {   
   printf("%c",stack[top]);  
   top--;   
   } 
}

This ought to fix the issues about pop function looking the correct place.

Note-THANK YOU SOO MUCH ...Problem solved xD

Originally Posted by Mayank Rikh

Problem solved xD

No, not at all. You forgot to consider the additional comment from iMalc:

Originally Posted by iMalc

However, you should also note that there is no NULL in your stack, so the while loop is broken anyway. You need another way of checking if the stack has anything in it or not. Perhaps you could use 'top'.

Bye, Andreas