2D array filling

[martynasj]

Hi, I need to fill 2D array with random numbers

#include <stdio.h> 
#include <stdlib.h> 
#include <time.h> 
int main() 
{ int i, j, n, m, *rod; 
srand(time(NULL)); 
n=rand()%10+1; 
m=rand()%10+1; 
printf("size %d x %d\n",n,m); 
rod=(int*)malloc(n*m*sizeof(int)); 
for(i=0;i<=n;i++) 
for(j=0;j<=m;j++) 
*(rod+j)=rand()%10+1; 
for(i=0;i<=n;i++) 
for(j=0;j<=m;j++) 
printf("%d\n",*(rod+j)); 
system("pause"); 
return 0; }

I think my code doesn't work properly, any ideas?

[std10093]

First style your code nicely .Read here .

You do not allocate memory as you should be.Remember that the 2D array is a normal array (1D) of pointers to int.Every pointer is set to a normal array.
Also because it is a 2D array, it should be a double pointer, not just a pointer,so not *rod but **rod.

If i want to access the element in i-th row and j-th column i have to write

array[i][j];

PS - i suggest you not to cast what malloc returns to you

[Matticus]

What are you exact requirements? What exactly is not "working properly" - please tell us what you expect and what is happening.

You're supposed to fill a 2D array with random numbers. Instead, you're randomly determining the size of storage - are you sure this is right? I don't see any arrays declared in your code.

And properly indent your code so it's readable.

[sean]

Your loops are set up properly to iterate through each possible combination of i and j, but then when you try to read or write a value, you're only using the current value of j, so you're basically looping over the first row a bunch of time, instead of moving on to the next row each time. What you should do is have a single value that keeps incrementing as you move through your matrix (instead of resetting it to 0 after each run, like your loops do), or you should calculate your position using i and j (e.g. i*j + j).

Also, I'd recommend using curly braces around your loops. Even though in this case it's not technically necessary, it helps makes the code easier to read and can help you avoid mistakes in your code - because you're being explicit about where the loop begins and ends. Also, don't forget to use nice indentation when you post - it's easier for people to help you.

[martynasj]

Oh sorry for that, I'm new here.
Now I want in each line find the smallest number, I tried with this code:

#include <stdio.h>
#include <stdlib.h>
#include <time.h>


int main() 
{
  int i, j, n, m, k, *min, *rod;
    srand(time(NULL));
    n=rand()%10+1;
    m=rand()%10+1;
        printf("lines %d columns %d\n",n,m);
        rod=(int*)malloc(n*m*sizeof(int));
        k = 0;
        
    for(i=0;i<n;i++)
        for(j=0;j<m;j++)
            *(rod+k++)=rand()%10+1;
    free(rod);
    k = 0;
    
    for(i=0;i<n;i++)
        { 
        printf("\n");
    
            for(j=0;j<m;j++)
             printf(" %d",*(rod+k++));
             printf("\n");
        }
//------------------------------------------//


  k=0;
  min=rod;
  *min=*rod;
    for(i=0;i<n;i++)
  {
         for(j=0;j<m;j++)
        
             if (*(rod+k++) < *min)
                 *min = *(rod+k++);
                   printf("smallest number in the line: %d\n", *min);
            
        
    }
  
system("pause");
  return 0;
}

but always i get zero's





what should I do?
Thanks for the help

[sean]

if (*(rod+k++) < *min)
    *min = *(rod+k++);

The ++ operator is dangerous when you use it like this. You're using it to mean "k+1" but it has side effects. The value of k will get incremented every time the conditional is evaluated, and then again every time it evaluates to true. This might also be why you're ending up with zeros. But what else have you tried to debug this? Learning to step through the code and see if what you think is happening is really happening is a critical skill - you won't get far if you just post your code and ask why it isn't working.

[iMalc]

You mustn't free something and then continue to use it. That is asking for a crash.