Problem retrieving information from a file line by line.

Well, I'm trying to scan though a file 'subdomains.txt' and print out what's on each line seperately. E.g.
file contains:

Code:

this
file
means
nothing_to_you

I want each line to be printed out. Here's what I've got so far:

Code:

#include <stdio.h>
#include <stdlib.h>
#include <string.h>
#include <tchar.h>


void retrieveSubdomains(void);


int main(int argc, char *argv[])
{
    
    retrieveSubdomains();
    system("pause");
    return 0;
}




void retrieveSubdomains()  //return subdomain
{
    TCHAR *filename = "subdomains.txt";
    FILE *fp = fopen(filename, "r"); /* _tfopen_s */
    TCHAR subs;
    TCHAR *fullSub = malloc(150*sizeof(TCHAR)); /* Couldn't be bothered with using realloc to update the size, so a set size will have to do. */
    short i = 0;


    if (fp != NULL)
    {
        while((subs = fgetc(fp)) != (TCHAR)feof)
        {
            while(subs != ' ' && subs != '\n')
            {
                fullSub[i] = subs;
                i++;
            }


            fullSub[i] = '\0';
            printf("%s\n", fullSub);
            //free(fullSub);
        }
    }else{
        fprintf(stderr, "Failed to open file '%s'!\n", filename);
    }
    free(fullSub);
}

My code crashes... Can you see what's wrong with it? Please and thank-you.

Code:

#include <stdio.h>
#include <stdlib.h>
#include <string.h>
#include <tchar.h>


void retrieveSubdomains(void);


int main(int argc, char *argv[])
{
    
	retrieveSubdomains();
    system("pause");
    return 0;
}




void retrieveSubdomains()  //return subdomain
{
	TCHAR *filename = "subdomains.txt";
	FILE *fp = fopen(filename, "r"); /* _tfopen_s */
    TCHAR subs;
    TCHAR *fullSub = malloc(150*sizeof(TCHAR)); /* Couldn't be bothered with using realloc to update the size, so a set size will have to do. */
    short i = 0;


    if (fp != NULL)
    {
			while((subs = fgetc(fp)) != (TCHAR)feof && subs != ' ' && subs != '\n')
			{
				printf("%c", fullSub[i] = subs);
				printf("%d", strlen(fullSub));
				i++;
			}


			fullSub[i] = '\0';
			printf("%d\n", sizeof *fullSub);
			//free(fullSub);
    }else{
        fprintf(stderr, "Failed to open file '%s'!\n", filename);
    }
	for(i=0;i<strlen(fullSub);i++)
		printf("%c", fullSub[i]);
		
	free(fullSub);
}

Thant's my current code, but I am having some problems, still. Strlen returns 6..? And I need to know how to jump to the next line? Would I just increment 'i' when I reach the newline character and it'll jump to the next line?

Originally Posted by inu11byte

Code:

			while((subs = fgetc(fp)) != (TCHAR)feof && subs != ' ' && subs != '\n')

You shouldn't use casts unless you understand why they're needed. Using them to hide compiler warnings is not a good reason (and yes, you should turn on and pay attention to all compiler warnings).

Originally Posted by christop

You shouldn't use casts unless you understand why they're needed. Using them to hide compiler warnings is not a good reason (and yes, you should turn on and pay attention to all compiler warnings).

Well... you're right, I shouldn't cast it like that. I'll change the while to:

Code:

while((subs = fgetc(fp)) != ' ' && subs != '\n' && !feof(fp))

Any ideas on why I'm get unexpected results? Or more improvements I could make?

Originally Posted by inu11byte

Any ideas on why I'm get unexpected results? Or more improvements I could make?

What are your unexpected results?

Right now, you're only reading the first line because of your while condition which stops when fgetc() reads in the newline character from the first line.

Bye, Andreas

You should look into using fgets(...) since it reads one line at a time.