Maze program question

Hi everyone, I have a question about a maze program i have to write. All i want to accomplish at the moment is to just locate the start and end coordinates of a maze the user would be inputting on stdin.

For some reason the program gives me the correct y coordinate but not the x.

For exp: if i were to input: 6 4
o#####
.#####
.#####
*#####

my program would tell me the start("o") is at 1 0(supposed to be 0 0) and that end(*) is at 4 0(supposed to be 3 0).

Thank you for your help!

Code:

#include<stdio.h>
#include<stdlib.h>
int main(void)
{
        int x;
        int y;
        int startx;
        int starty;
        int finishx;
        int finishy;
        char a;
        
        int tempx=0;
        int tempy=0;


        scanf("%d %d", &y, &x);






        char maze[x][y];        
        
        for(;tempx<=x;tempx++)
        {
        
                fgets(maze[tempx],y+2,stdin);
        }






 for(tempx=1;tempx<x+1;tempx++){
                for(tempy=0;tempy<y;tempy++){


                        a=maze[tempx][tempy];
                        if(a=='o')
                        {
                                printf("start position: %d %d\n", tempx, tempy);
                                startx=tempx;
                                starty=tempy;
                        }


                        if(a=='*')
                        {
                                printf("end position: %d %d", tempx, tempy);
                                finishx=tempx;
                                finishy=tempy;


                        
                         
                        }
                        
                } 


        }

You need to post your code if you want help.

According to your post, just subtract 1 from x before printing its value.

code is posted

Arrays, in C, start at index 0.
Your loops should be from 0 to just before the length of the array
for (index = 0; index < length; index++)

I did that at the beginning the reason why i started at 1 was because before i started to find the start and end points i tried to print out the maze just as a test. I used the normal way but for some reason it would never print the last line of the array. And some weird numbers and chars would appear in the first line.

What i think is that fgets is scanning the coordinates i put for scanf and putting that into the array as well as the maze chars i entered. Thats why im getting those jumbled up numbers and chars. But im not sure how to fix that

Originally Posted by stpeng

Code:

       char maze[x][y];        
        
        for(;tempx<=x;tempx++)
        {
        
                fgets(maze[tempx],y+2,stdin);
        }

You have two different causes of buffer overrun there.
1. tempx goes up to x, but the first dimension of x is only valid from 0 to x-1
2. You're telling it that each "string" is y+2 characters long, when in fact it is only y characters long.

Note that I meant "the first dimension of maze", not of x, in 1 above.