Thread: Array for status history?

Why bother with an array? It seems that a simple count of consecutive 0's is enough:

Code:

    int cnt = 0;

    // inside your loop
        if (status == 0) {
            if (++cnt >= 30)
               flag = 1; // you may also want to reset cnt to 0
        }
        else
            cnt = 0;

[edit] Whilst replying you seem to have sorted it out - So don't worry about this. [/edit]

I'm guessing you are programming some micro-controller

I'm guessing by FILO, you mean First-in-last-out -> Or more commonly "LIFO" (Last in first out)

You need to create a stack.

Originally Posted by Rick19468

Brutal Juice! ...... thanks! : )

That sounds nasty!
You're welcome, though.

Not sure that I like the variable incrementing during a conditional, but that's a minor niggle and is easily resolved.

It is amazing how often you can overlook the simple way, though. I watched a small group of people once trying to compensate for what happened when you needed to switch between two players (numbered player one and player two). The sheer amount of them that fell into the trap of:

Code:

if(player == 1)
     player = 2;
if(player == 2)
    player = 1;

was astounding and they came up with all manner of ways to compensate for the problem with that code with extra variables, using min(), max(), modulo arithmetic and all sorts.

When they asked to see my line, they kicked themselves. We had suitable-enough preconditions and constraints to be able to do just:

Code:

player = 3 - player;

Not saying it was *good* code but it was amazing how many of them missed the simple.

Originally Posted by ledow

We had suitable-enough preconditions and constraints to be able to do just:

Code:

player = 3 - player;

Not saying it was *good* code but it was amazing how many of them missed the simple.

In my opinion, the simple is:

Code:

player = (player == 1) ? 2 : 1;

What you came up with is not so simple because it relies on a magic number (and mathematical property), rather than the simple "if it is this player, then the next player must be that, otherwise it must be this" logic. Rather, it is elegant, being more concise, and probably more efficient.

I have to admit that I like laserlight's solution because it's self documenting -> It's something you would know exactly what is happening in the code.

However, being the person I am, I came up with my own small solution that would make no sense to the next person coming along!

Code:

player ^= 3;