Guessing Game

**ryansanford** · 09-30-2012

This is what I have for a user-defined range and everything works properly until I upload it to the upload site. The first run works but the second run gives an infinite output of "Too Low". What am I doing wrong?

Code:

#include <stdio.h>
#include <stdlib.h>
#define min(a,b) ((a)>(b)?(b):(a))
int main ()
{
    unsigned int a,b,count=0,range;
    unsigned int guess=0,answer;
    printf("Enter 2 integers for the range\n");
    scanf("%d %d", &a, &b);
    printf("I'm thinking of a number between %d and %d\n", a, b);
    range=b-a;
    srand(min(a,b));
    answer=(rand()%(range+1)+a);
    while(guess!=answer)
    {
    printf("Pick a number\n"); 
    scanf("%d",&guess);
    if(guess==answer)
        {
        printf("You guessed correctly\n");
        }
    else if(answer< guess)
        {
            printf("Your guess is too high\n");
        }
    else
        {
            printf("Your guess is too low\n");
        }
    count++;
    }
    printf("It took you %d time(s)\n", count);
    return 0;
}

**Adak** · 09-30-2012

If you want to have the user able to play more than one time, you need to add a second while loop, around everything you have here, EXCEPT the srand() line of code. That line should be moved up and only executed ONE time (not once per game).

Other than that, line #8 is where the new while loop should start, and it should extend to where the user shows he doesn't want to play any more guessing games (ready to exit).

If that's not your question, then show a game or two, and what it is that you want here.

**AndiPersti** · 10-01-2012

Originally Posted by ryansanford

This is what I have for a user-defined range and everything works properly until I upload it to the upload site.

What do you mean with "upload it to the upload site?

Originally Posted by ryansanford

The first run works but the second run gives an infinite output of "Too Low". What am I doing wrong?

It is always easier for us if you tell us for which inputs the program doesn't work.
So my guess it that the second time you have inputted the higher limit before the lower one, right?

Code:

$ ./test
Enter 2 integers for the range
3 1
I'm thinking of a number between 3 and 1
Pick a number
2
Your guess is too low
Pick a number
3
Your guess is too low
Pick a number

Now look at your code:

Code:

unsigned int a,b,count=0,range;
unsigned int guess=0,answer;
printf("Enter 2 integers for the range\n");
scanf("%d %d", &a, &b);
printf("I'm thinking of a number between %d and %d\n", a, b);
range=b-a;
srand(min(a,b));
answer=(rand()%(range+1)+a);

You assume that "a" will always be the smaller number. But if "b" is the smaller one, "range" will be negative. Because "range" is unsigned, it's value is (b - a) + (UINT_MAX + 1) which is probably a very big number (e.g. in my example (1 - 3) = -2, adding UINT_MAX + 1 on my system (32bit integers) will be -2 + 4294967295 + 1 = 4294967294).
As a consequence "answer" will probably be a very big number too.

Another problem is how you use srand(). Since you seed the pseudorandom number generator with the smaller value of "a" and "b", you will always get the same "random" number if you play the game several times with the same input values.

Bye, Andreas

Thread: Guessing Game

Thread Tools

Search Thread

Display

Guessing Game

Similar Threads

Guessing game: how to quit the game?

guessing game

guessing game

A guessing game

guessing game

Tags for this Thread