fprintf isn't outputting anything to file

[RagingPenguin4]

I am trying to use the following c code to print out an array that I have passed in. It should output the text in hexadecimal format one on each line. When I first wrote it, I had no problems with it working I opened the output file and my array was there. I changed the fileOutName parameter and now I can't get it to print out anything. Any help would be appreciated. Thanks

 printoutput(int  output[],char * fileOutName){
    int i=0;
    FILE * pOutfile;
    pOutfile = fopen( fileOutName, "w" );
    while(output[i]!=0){
        fprintf( pOutfile, "0x%0.4X\n", output[i]);
        i++;
}

[oogabooga]

Your fprintf has a constant 5 as the output value. You probably want (and probably had before) output[i] there.

Shouldn't you check that the file opened properly?

Shouldn't you close the file before returning from the function?

Your while loop is a perfect candidate for a for loop.

[RagingPenguin4]

Sorry the 5 was an something that I had for testing that I didn't realize was there but I put the output[i] back in its place where it should be. I would have used a for loop but I didn't have the array length

[oogabooga]

Try this. Does it work? If not, what happens?

void printoutput(int output[], char *fileOutName) {
    int i;
    FILE *pOutFile = fopen(fileOutName, "w");
    if (pOutFile == NULL) {
        fprintf(stderr, "fopen failed\n");
        exit(1);
    }
    for (i=0; output[i]!=0; i++)
        fprintf(pOutfile, "0x%0.4X\n", output[i]);
    fclose(pOutFile);
}

[Click_here]

Hey oogabooga - I think that you may have missed an opening '{' at the start of the function.

[oogabooga]

Hey oogabooga - I think that you may have missed an opening '{' at the start of the
function.

Thanks click. I've fixed it.

[RagingPenguin4]

Hmm not sure why that fixed it but at least it works now. On a semi-related note whenever I make that function void, Visual studios doesn't like it however it isn't returning anything :/
Thanks!

[laserlight]

What compiler error/warning do you get?

[RagingPenguin4]

error C2371: 'printoutput' : redefinition; different basic types
Although i think i figured it out, in my prototype I had left out the return type and I am assuming (can't remember exactly) that the default return type is an int so when I declared it void it clashed with the prototype.