Thread: My idea.

Originally Posted by Adak

C'mon, you know this can't be right!

Code:

    do {
        printf("Please provide a temperature less that 200C.\n");  //Asks for a temperature for the higher temperature,
        scanf("%d", &high);
        printf("\n");
    } while (high > UPPER);                                        //and checks to make sure it is less than 200C.

Think through your loops, a bit more. UPPER is 200, and you want high to be something LESS than that.

Think through your loops a bit more. If high is more than the upper limit, I think you should repeat. > and < is all about the placement of the arguments.

Originally Posted by whiteflags

Think through your loops a bit more. If high is more than the upper limit, I think you should repeat. > and < is all about the placement of the arguments.

Yes, it was meant to be a satire about using a while loop for user's who can't read.

After I wrote it, I realized it might not be seen as such, which is why it was removed.

Originally Posted by whiteflags

Think through your loops a bit more. If high is more than the upper limit, I think you should repeat. > and < is all about the placement of the arguments.

That was a loop to ask them to re-enter a temperature if high > the upper limit. I see nothing wrong with that bit of code.

Want to explain what is wrong with it?

I see nothing wrong with it either. I was contradicting the person I quoted.

Originally Posted by Adak

Yes, it was meant to be a satire about using a while loop for user's who can't read.

After I wrote it, I realized it might not be seen as such, which is why it was removed.

As you see from the above, it seems to be an attempt at humor on the internet that went horribly wrong.

Gotcha. I thought i did a pretty decent job, and actually preferred it to the "solution." Sure I could enable it to input bigger numbers I guess. But overall I was pretty happy with it.

Code:

#define UPPER 200
...
do {
    printf("Please provide a temperature less that 200C.\n");  //Asks for a temperature for the higher temperature,
    scanf("%d", &high);
    printf("\n");
} while (high > UPPER);                                        //and checks to make sure it is less than 200C.

If you use a macro for constant values you should use it everywhere in your code. Otherwise it's rather useless.

Code:

do {
    printf("Please provide a temperature less than %dC.\n", UPPER); 
    scanf("%d", &high);
    printf("\n");
} while (high > UPPER);

And it's "Fahrenheit" :-)

Bye, Andreas

Originally Posted by AndiPersti

Code:

#define UPPER 200
...
do {
    printf("Please provide a temperature less that 200C.\n");  //Asks for a temperature for the higher temperature,
    scanf("%d", &high);
    printf("\n");
} while (high > UPPER);                                        //and checks to make sure it is less than 200C.

If you use a macro for constant values you should use it everywhere in your code. Otherwise it's rather useless.

Code:

do {
    printf("Please provide a temperature less than %dC.\n", UPPER); 
    scanf("%d", &high);
    printf("\n");
} while (high > UPPER);

And it's "Fahrenheit" :-)

Bye, Andreas

Could you explain how I should use a macro everywhere? And point out which term is considered a Macro?
Also thanks for the spelling. I can never spell Fahrenheit. And I couldn't figure out spell check in my coder.

Originally Posted by Zach Sisk

Could you explain how I should use a macro everywhere? And point out which term is considered a Macro?

Code:

printf("Please provide a temperature less that 200C.\n");

vs

Code:

printf("Please provide a temperature less than %dC.\n", UPPER);

the UPPER is the macro which is expanded to the literal value you set it to , before compilation.

Originally Posted by manasij7479

Code:

printf("Please provide a temperature less that 200C.\n");

vs

Code:

printf("Please provide a temperature less than %dC.\n", UPPER);

the UPPER is the macro which is expanded to the literal value you set it to , before compilation.

Gotcha, didn't think about that. Thanks.