problem with bubble sort

[Dave Couture]

void 
sort(int values[], int n)
{
    int swapped = 1;
    while (swapped == 1)
        swapped = 0;
        for (i = 0; i < (n - 1); i++)
            if (values[i] > values[i + 1])
            {
                int temp = values[i];
                values[i] = values[i+1];
                values[i+1] = temp;
                swapped = 1;
            }
    else
        return 0;         
}

I'm running Fedora and compiling with gcc. I don't know why but it is not compiling. I get this error: jharvard@appliance (~/pset3): make helpers make: *** No rule to make target `helpers'. Stop.

[root4]

Hmm... this error has nothing to do with the compiler or your code, it's a problem with the makefile.
The rule "helpers" apparently doesn't exist or maybe the name of the makefile is not standard and you have to specify it on the command line.

[Dave Couture]

here is the makefile

#
# Makefile
#
# Computer Science 50
# Problem Set 3
#

all: find generate

find: find.c helpers.c helpers.h
    gcc -ggdb -std=c99 -Wall -Werror -o find find.c helpers.c -lcs50 -lm

generate: generate.c
    gcc -ggdb -std=c99 -Wall -Werror -o generate generate.c

clean:
    rm -f *.o a.out core find generate

[iMalc]

Even once that compiles, there is a very obvious bug in that your while loop only embodies line 6, and not lines 7 - 14.
You also can't return 0 from a void returning function, not that you want a return statement in this function at all anyway.

[anduril462]

here is the makefile

#
# Makefile
#
# Computer Science 50
# Problem Set 3
#

all: find generate

find: find.c helpers.c helpers.h
    gcc -ggdb -std=c99 -Wall -Werror -o find find.c helpers.c -lcs50 -lm

generate: generate.c
    gcc -ggdb -std=c99 -Wall -Werror -o generate generate.c

clean:
    rm -f *.o a.out core find generate

Yep, root4 called it: you don't have a 'helpers' target in your make file. You have targets 'all', 'find', 'generate' and 'clean'. If you want to use the command 'make helpers', you must write a 'helpers' target. Follow the pattern used for find and generate. You should also try reading a tutorial or two on using make and on writing make files. Check the tutorials on our site.