Thread: Trouble with opening files

I'm currently taking a C programming class over the summer right now. I'm using Visual Studio 2010. I really enjoy the class and am doing really well in it but I have a problem opening files in visual studio. I tried writing a program and I keep getting problems creating, opening files. I checked, double-checked, umpteenth-checked my code and it seems okay.

Then I tried even the most basic file opening programs and it still won't open the dang file.

This is merely a practice program. I took it directly from the book. The code compiles successfully but when it runs. Without fail it goes to the Error opening student file

Code:

#include <stdio.h>


int getstu(FILE* spstu, int* stuid, int* exam1, int* exam2, int* final);
int writestu(FILE* spgrades, int stuid, int average, char grade);
void calcgrade(int exam1, int exam2, int final, int* average, char* grade);


int main(void)
{
	FILE* spstu;
	FILE* spgrades;


	int stuid;
	int exam1;
	int exam2;
	int final;
	int average;


	char grade;


	printf("Begin student grading\n");
	if (!(spstu = fopen ("P07-06.DAT", "r")))
	{
		printf("\aError opening student file\n");
		return 100;
	}


	if (!(spgrades = fopen ("P07-06Gr.DAT", "w")))
	{
		printf("\aError opening grades file\n");
		return 102;
	}


	while (getstu(spstu, &stuid, &exam1, &exam2, &final))
	{
		calcgrade(exam1, exam2, final, &average, &grade);
		writestu(spgrades, stuid, average, grade);
	}


	fclose(spstu);
	fclose(spgrades);


	printf("End student grading\n");
	return 0;
}


int getstu(FILE* spstu, int* stuid, int* exam1, int* exam2, int* final)
{
	int ioresult;
	ioresult = fscanf(spstu, "%d%d%d%d", stuid, exam1, exam2, final);
	if(ioresult == EOF)
		return 0;
	else if(ioresult != 4)
	{
		printf("\aError reading data\n");
		return 0;
	}
	else
		return 1;
}


void calcgrade(int exam1, int exam2, int final, int *average, char* grade)
{
	*average = (exam1 + exam2 + final) / 3;
	if (*average >= 90)
		*grade = 'A';
	else if(*average >= 80)
		*grade = 'B';
	else if(*average >= 70)
		*grade = 'C';
	else if(*average >= 60)
		* grade = 'D';
	else
		*grade = 'F';
	return;
}


int writestu(FILE* spgrades, int stuid, int average, char grade)
{
	fprintf(spgrades, "%04d %d %c\n", stuid, average, grade);
	return 0;
}

Maybe I need a better understanding of files but my book isn't very helpful. I think it (maybe?) might be a setting in Visual Studio I have to change????

I should get rid of those "\a"s those guys are annoying me...

Yes.The problem is that VS can not find the file you ask for.The fopen function returns NULL(as it ought to do),because the file requested was not found.I think you should put a suitable path on your project in order to find the file.Search the google Or wait until a VS user sees that post

Ahhhh... I see. So I must actually write a text file in the directory named P07-06.DAT?

cfanatic: the paths in VS are for the build steps. They tell the compiler and linker where to find source files, header files, object files, library files, resource files, etc. The program itself doesn't automatically learn about these paths from Visual Studio.

Also you mention using \\ in string literals for path separators for Windows, which is correct, but your examples use //, which is not correct. Slash and backslash are two completely different symbols in C. Of course, everytime I've had the "pleasure" (more like pain) of coding for Windows I alway use a single slash as a path separator, and it works fine. I think all the C file functions in Windows accept either backslashes or slashes. I also prefer slashes because they are The One True Path Separator . After all, the Web uses slash, Unix uses slash, MacOS X uses slash (well, that's Unix too), etc.

Originally Posted by christop

cfanatic: the paths in VS are for the build steps. They tell the compiler and linker where to find source files, header files, object files, library files, resource files, etc. The program itself doesn't automatically learn about these paths from Visual Studio.

Actually there is a setting in the VS IDE called something like working directory. When the program is run from the IDE then the current working directory is set to that path before execution. This way you can use relative path in your programs. Beware that this path can be set to different locations for debug and release builds.

Kurt

Originally Posted by ZuK

Actually there is a setting in the VS IDE called something like working directory. When the program is run from the IDE then the current working directory is set to that path before execution. This way you can use relative path in your programs. Beware that this path can be set to different locations for debug and release builds.

Kurt

Well, I stand corrected. I guess it does make sense to have a setting for the working directory while running the program too.