fill in a struct with fscanf

Please I need help, I can't find my bug...

data.txt contains:
/* name surname integer integer */
name surname 011 111
name surname 1 2
...

then:

Code:

#include <stdio.h>
#include <string.h>
#include <stdlib.h>

struct person {
    char *name, *surname;
    int age, income;
};

struct person *init(void)
{
    struct person *p;
    p = (struct person *) malloc(sizeof(struct person));
    p->name = NULL;
    p->surname = NULL;
    p->age = 0;
    p->income = 0;
    return p;
}

int main(void)
{
    FILE *fp = fopen("data.txt", "r");
    struct person *list[10]; /* no matter... */
    int register i = 0;

    while (!feof(fp)) {
        list[i] = init();
        fscanf(fp, "%s %s %d %d\n", list[i]->name, list[i]->surname, &(list[i]->age), &(list[i]->income));
        i++;
    }
    fprintf("%s %s\n", list[0]->name, list[0]->surname);
    fclose(fp);
    return 0;
}

But it does not work! can anyone provide help?
Cheers
DBG

How does it not work?

It's not enough to just malloc sizeof(struct person) since you are reading strings to p->name and so on. p->name is just a pointer, it's meant to point to where your string are only, not contain the string.

AS a side note

Code:

while (!feof(fp))

do not use feof to control input loop - read FAQ FAQ > Why it's bad to use feof() to control a loop - Cprogramming.com

Originally Posted by laserlight

How does it not work?

Actually, line 32, we should have in output: name surname 011 111

but it does not...

fprintf(stdout, "%s %s\n", list[1]->name, list[1]->surname);

should printout regarding data.txt:

name surname 1 2

Instead I do have: core dumped...

Start with

Code:

struct person {
//    char *name, *surname;
    char name[100], surname[100];
    int age, income;
};

until you understand the finer points of memory allocation.

And please read the FAQ on how to use feof() properly (which you are not).

Originally Posted by Salem

Start with

Code:

struct person {
//    char *name, *surname;
    char name[100], surname[100];
    int age, income;
};

until you understand the finer points of memory allocation.

Thanks. I went for p->name = malloc(/* */);

And please read the FAQ on how to use feof() properly (which you are not).

Yes SIR!