How to clean the string?

[ulti-killer]

The strings stack again and again. I dunno how to clear and reset it.

#include <stdio.h>
#include <string.h>
#include <stdlib.h>
 
 
int main()
{
    char performance [23] = "Performance: ", performance1 [10], rate [3] ="", rate1 [3], yesno;
    int a;


    do
    {
    printf("Enter value: ");
    scanf(" %d", &a);


    
    if (a >= 2000)
    {
        strcpy (performance1,"Excellent");
        strncat (performance, performance1,9);
        strcpy (rate1,"7%");
        strncat (rate, rate1,3);    
    }
    
    else if (a>= 1000)
    {
    
        strcpy (performance1,"Good");
        strncat (performance, performance1,4);
        strcpy (rate1,"5%");
        strncat (rate, rate1,3);
    }
    
    else
    {
        strcpy (performance1,"Fair");
        strncat (performance, performance1,4);
        strcpy (rate1,"3%");
        strncat (rate, rate1,3);
    }
    
    printf("%s\n", performance);
    printf("%s\n", rate);


    printf("Continue (Y/N)? ");
    scanf(" %c",&yesno);
    }while (yesno == 'Y' || yesno == 'y');
 
}

[laserlight]

What makes you think the string is dirty?

[ulti-killer]

If I say flush is that correct?

[laserlight]

Heheh, that was a joke

Anyway, my suggestion is that you declare those strings in the body of the do while loop. This way, they will be "reset" at the start of each iteration.

Also, I have not checked, but be careful not to exceed the bounds of the array. You should also indent your code a little better, particularly the body of the loop.

[ulti-killer]

Thank you very much. By the way, I dunno need to indent which line of code.

#include <stdio.h>#include <string.h>
#include <stdlib.h>
 
 
int main()
{
    char yesno;


    do
    {
    char performance [23] = "Performance: ", performance1 [10], rate [3] ="", rate1 [3];
    int a;


    printf("Enter value: ");
    scanf(" %d", &a);


    
    if (a >= 2000)
    {
        strcpy (performance1,"Excellent");
        strncat (performance, performance1,9);
        strcpy (rate1,"7%");
        strncat (rate, rate1,3);    
    }
    
    else if (a>= 1000)
    {
    
        strcpy (performance1,"Good");
        strncat (performance, performance1,4);
        strcpy (rate1,"5%");
        strncat (rate, rate1,3);
    }
    
    else
    {
        strcpy (performance1,"Fair");
        strncat (performance, performance1,4);
        strcpy (rate1,"3%");
        strncat (rate, rate1,3);
    }
    
    printf("%s\n", performance);
    printf("%s\n", rate);


    printf("Continue (Y/N)? ");
    scanf(" %c",&yesno);
    
    performance [23];
    rate [3];
    }while (yesno == 'Y' || yesno == 'y');
 
}

[laserlight]

I might format your program like this:

#include <stdio.h>
#include <string.h>
#include <stdlib.h>

int main()
{
    char yesno;
    do
    {
        char performance[23] = "Performance: ", performance1[10], rate[3] = "", rate1[3];
        int a;

        printf("Enter value: ");
        scanf(" %d", &a);

        if (a >= 2000)
        {
            strcpy(performance1, "Excellent");
            strncat(performance, performance1, 9);
            strcpy(rate1, "7%");
            strncat(rate, rate1, 3);
        }
        else if (a >= 1000)
        {
            strcpy(performance1, "Good");
            strncat(performance, performance1, 4);
            strcpy(rate1, "5%");
            strncat(rate, rate1, 3);
        }
        else
        {
            strcpy(performance1, "Fair");
            strncat(performance, performance1, 4);
            strcpy(rate1, "3%");
            strncat(rate, rate1, 3);
        }

        printf("%s\n", performance);
        printf("%s\n", rate);

        printf("Continue (Y/N)? ");
        scanf(" %c", &yesno);

        performance[23];
        rate[3];
    } while (yesno == 'Y' || yesno == 'y');
}

A few things to note:

• By and large, you don't need the performance1 array. You can copy the string literal directly. In fact, your use of strncat is slightly off in each case because you fail to account for the null character, though you are saved by proper initialisation of the performance array.
• Likewise for the rate1 array: it would be simpler to have used the string literal directly.
• At the end of the body of the loop, you mysteriously access the performance and rate arrays out of bounds. Remove those lines.

[ulti-killer]

How to do?

[laserlight]

For example:

strcat(performance, "Excellent");

You should be careful to ensure that the destination array has enough space for the concatenation. In this case, it has just enough space.

[ulti-killer]

I mean how to copy the string literal directly? I can't figure out a better solution.

[laserlight]

My example in post #8 is what I mean by copying the string literal directly, i.e., instead of first copying to another array, then using strncat with that other array.

[ulti-killer]

My example in post #8 is what I mean by copying the string literal directly, i.e., instead of first copying to another array, then using strncat with that other array.

Thanks. Why i do a lot of redundant things?