Thread: Xstrcpy-replace all characters in a string with single character..

Code:

#include<stdio.h>
#include<stdlib.h>
#include<string.h>
void xstrchr(char*,char);
int main()
{
    char *target;
    char s;
    int l;
    printf("Enter the target\t");
    gets(target);
    printf("%s\n",target);  /*debug*/
    printf("Enter the character\t");
    scanf("%c",&s);
    xstrchr(target,s);
}




void xstrchr(char *target,char s)
{
    printf("\n%s\n",target); /*debugging*/
    while(*target!='\0')
{
    *target=s;
   printf("%s\n",target);


   *target++;
     }


}

Aim : Replace all characters in a string with single character,

but the problem is "*target++" .

i am not able to print the entire replaced string


i have attached the execution to the post

Originally Posted by QuantumPete

There is no memory allocated for your target variable. You're basically using gets (which is bad by itself, you should use fgets) to write into a random part of memory. This is called undefined behaviour and is (to quote laserlight) a Bad Thing.

extern char *fgets (char *__restrict __s, int __n, FILE *__restrict __stream)
__wur;

* Get a newline-terminated string from stdin, removing the newline.
DO NOT USE THIS FUNCTION!! There is no limit on how much it will read.


This function is a possible cancellation point and therefore not
marked with __THROW. */


i have started c programming recently, i am sorry but i didnt get ur answer..
i tried replacing gets with fgets..

but what i want to do is a c programs ( so i didnot include a iostream)

fgets needs more arguments, i was not able to understand what i need to place in " fgets(..) "..


.................................................. ...............................
i want to do this program using pointers is because it is space efficient.. i could have done it using arrays..
but the flexibility of the program will be affected ( size of string )..

if u could repair my code .. i would be grateful..
........................
Sorry for my bad english..

what i want is:
string : target
character to replace with : r

OUTPUT :
rrrrrr

Originally Posted by thriller500

Aim : Replace all characters in a string with single character,

but the problem is "*target++" .

i am not able to print the entire replaced string

There is another problem here, you are printing inside your loop with %s, that is why you get the current character 's' and the remaining string that is not yet changed. Just remove the printf in the loop and print target in it's entirety after you called your function.

> Replace all characters in a string with single character,

Code:

memset(target, s, strlen(target));