Problem with Dice Program

[Lambarda]

So i am trying to create a sort of dice game that when the numbers 7 or 11 are rolled on the first roll you win, but if a 2,3 or 12 are rolled you lose.
But if any other number is produced the program jumps to the while loop and starts spitting out numbers until either a 7 is rolled or you roll the same number you started with.

Here is my program;

#include<stdio.h>
int main()
{
    /*declare*/
    int D1;
    int D2;
    int sum, sum2, point;
    printf("Press Any Key To Start");
    getchar();
    srand(time(0));
    D1 = 1 + rand() % 6;
    D2 = 1 + rand() % 6;
    sum = D1 + D2;
    printf("\nRoll: %d\n", sum);
    if ( sum == 7)
        printf("\nYou Win");
    if (sum == 11)
        printf("\nYou Win");
    if (sum == 2)
        printf("\nYou lose");
    if (sum == 3)
        printf("\nYou lose");
    if (sum == 12)
        printf("\nYou lose");
    point = sum;
     while((sum2!=1)&&(sum2!=sum))
    {
        D1 = 1 + rand() % 6;
        D2 = 1 + rand() % 6;
        sum2 = D1 + D2;
        printf("  \nRoll: %d+%d=%d\n ", D1, D2, sum2);
    }
    if (sum2 == 7)
    {
        printf("You lose");
    }
    else 


    {
        printf("\nyou win");
    }
}

Now my problem is when the dice rolls and the first if statement is met it still jumps to the while loop instead of ending the program, and also for some reason the while loop doesnt like the;

if (sum2 == 7)
printf("You lose");

as when it prints 7 it completly ignores it.

Any ideas?


Thanks for your help in advance.

[Salem]

> while((sum2!=1)&&(sum2!=sum))
Why are you comparing with 1, if you're looking for a 7 ?

[Lambarda]

Okay
i managed to get the while loop to accept the

if(sum2 == 7)
    {
        printf("You lose");

Now i just need a 2nd opinion with how to stop the program if any of the inital if statement conditions are met.

New code(minor adjustment)

#include<stdio.h>
int main()
{
	/*declare*/
	int D1;
	int D2;
	int sum, sum2, point;
	printf("Press Any Key To Start");
	getchar();
	srand(time(0));
	D1 = 1 + rand() % 6;
	D2 = 1 + rand() % 6;
	sum = D1 + D2;
	printf("\nRoll: %d\n", sum);
	if ( sum == 7)
		printf("\nYou Win");
	if (sum == 11)
		printf("\nYou Win");
	if (sum == 2)
		printf("\nYou lose");
	if (sum == 3)
		printf("\nYou lose");
	if (sum == 12)
		printf("\nYou lose");
	point= D1+D2;
	while ((sum2 != 7) && (sum2 != sum))
	{
	
		D1 = 1 + rand() % 6;
		D2 = 1 + rand() % 6;
		sum2 = D1 + D2;
		printf("  \nRoll: %d+%d=%d\n ", D1, D2, sum2);
		}
		
		if (sum2 == 7 )
		{
			printf("\nYou lose");
		}
		else if (point = sum2 )
		{
			printf("\nYou win");
		}
	}

[Lambarda]

was a miss type when fiddling around, change it since

[Lambarda]

Yay, i got it finished!
here is my program for people interested in what i changed. ( all i had to add was return 0; not pretty but made it work :P)

#include<stdio.h>
int main()
{
	/*declare*/
	int D1;
	int D2;
	int sum, sum2, point;
	printf("Press Any Key To Start");
	getchar();
	srand(time(0));
	D1 = 1 + rand() % 6;
	D2 = 1 + rand() % 6;
	sum = D1 + D2;
	printf("\nRoll: %d\n", sum);
	if ( sum == 7)
	{
		printf("\nYou Win");
		getchar();
		return 0;
	}
	if (sum == 11)
	{
		printf("\nYou Win");
		getchar();
		return 0;
	}
	if (sum == 2)
	{
		printf("\nYou lose");
		getchar();
		return 0;
	}
	if (sum == 3)
	{
		printf("\nYou lose");
			getchar();
		return 0;
	}
	if (sum == 12)
	{
		printf("\nYou lose");
		getchar();
		return 0;
	}
	point = D1 + D2;
	while ((sum2 != 7) && (sum2 != sum))
	{
		D1 = 1 + rand() % 6;
		D2 = 1 + rand() % 6;
		sum2 = D1 + D2;
		printf("  \nRoll: %d+%d=%d\n ", D1, D2, sum2);
	}
	if (sum2 == 7 )
	{
		printf("\nYou lose");
	}
	else if (point = sum2 )
	{
		printf("\nYou win");
	}
}

Thanks for the replies and help!

[QuantumPete]

	else if (point = sum2 )
	{
		printf("\nYou win");
	}
}

This doesn't do what you want. It will always be true if sum2 is not 7 but greater than 0. Remember that there's a difference between assignment (=) and an equality check (==)

[AndiPersti]

    if ( sum == 7)
    {
        printf("\nYou Win");
        getchar();
        return 0;
    }
    if (sum == 11)
    {
        printf("\nYou Win");
        getchar();
        return 0;
    }
    if (sum == 2)
    {
        printf("\nYou lose");
        getchar();
        return 0;
    }
    if (sum == 3)
    {
        printf("\nYou lose");
            getchar();
        return 0;
    }
    if (sum == 12)
    {
        printf("\nYou lose");
        getchar();
        return 0;
    }

Do you know that C has boolean operators like and (&&) and or (||) so that you can simplify your 5 if-checks to just 2?

Out of curiosity: Is this exercise from the book "C Programming - A Modern Approach" from K.N.King?

Bye, Andreas