command line args problem

[coderplus]

I have a problem checking on the command line args.

int main(int argc, char* argv[])
{
printf("%s",argv[1]);
if (argv[1]=="hello")
 printf("works!");
return 0;
}

But for some reason the "if" doesn't pass. Eventhough it does prints out what the "if" states.

Why is that?

[jimblumberg]

What do you mean the "if doesn't pass". What does this program output?

You should be using the strcmp() function to compare your strings, not the comparison operator==.

Jim

[hk_mp5kpdw]

You need to use strcmp to compare strings in C. As it stands, your equality test is trying to compare the address of argv[1] with the address of the string literal "hello". These two addresses will NEVER be the same.

[coderplus]

Ahah, got it. Thanks.

[QuantumPete]

You should check argc to ensure you're being passed enough arguments before you start using argv[1]!
Also you should indent your code and use curly braces for the if statement.