Error C2109 + C2228

[deeisenberg]

Okay so I have a global structure defined as...

struct branch { /*branches*/
    char trait[385];
    int counter[386];
} b[64];

I have this structure defined and use it in several programs with similar goals. All of the programs work except for one that is more complicated into which I put an extra function that allows me to shorten the length of the code. The function is...

void ev(int a, int b, int c) {    
    int i;
    for(i=0; i<a; i++) {
        b[b].trait[i]=b[c].trait[i];
        b[b].counter[i]=b[c].counter[i];
    }
    b[b].counter[a]=b[c].counter[a];
    for(i=a; i<385; i++) bsim(i, b);
}

When I try to run the build the program it says that on the 4th, 5th, and 7th lines of that code above have errors C2109 and C2228. I don't understand what is wrong with them because when I use almost identical formats in other parts of this program and others it works just fine. Any help with how to fix the problem would be appreciated.

[rags_to_riches]

We're not Microsoft compilers, we're people. We don't have Microsoft's compiler error codes committed to memory. How about copying and pasting all the errors exactly as they appear?

[deeisenberg]

1>Yule64-1.cpp(915): error C2109: subscript requires array or pointer type
1>Yule64-1.cpp(915): error C2228: left of '.trait' must have class/struct/union
1>Yule64-1.cpp(915): error C2109: subscript requires array or pointer type
1>Yule64-1.cpp(915): error C2228: left of '.trait' must have class/struct/union
1>Yule64-1.cpp(916): error C2109: subscript requires array or pointer type
1>Yule64-1.cpp(916): error C2228: left of '.counter' must have class/struct/union
1>Yule64-1.cpp(916): error C2109: subscript requires array or pointer type
1>Yule64-1.cpp(916): error C2228: left of '.counter' must have class/struct/union
1>Yule64-1.cpp(918): error C2109: subscript requires array or pointer type
1>Yule64-1.cpp(918): error C2228: left of '.counter' must have class/struct/union
1>Yule64-1.cpp(918): error C2109: subscript requires array or pointer type
1>Yule64-1.cpp(918): error C2228: left of '.counter' must have class/struct/union

[rags_to_riches]

void ev(int a, int b, int c) {

b[b].trait[i]=b[c].trait[i];

Yup, b is neither a pointer nor an array, nor the struct you want to treat is as.

[Salem]

Perhaps the real question is why you're giving a global variable such a stupid and meaningless name as 'b'.

Especially when you're using the same for parameter names.

Introduce some naming convention so the two never collide, say all globals are CamelCaseWithFirstLetterCapitalised and all locals are just lowercase.

[claudiu]

We're not Microsoft compilers, we're people. We don't have Microsoft's compiler error codes committed to memory. How about copying and pasting all the errors exactly as they appear?

Speak for yourself! Just kidding.

As for the OP maybe if you didn't name the whole variable set b, bbb ,bbbbbb and other b names the compiler could actually tell if you are referring to some poorly typedefed struct or to your equally ambigous function parameter.

EDIT: I meant to say struct declaration, just saw now that you didn't actually typedef anything.

[deeisenberg]

It's all fixed now thanks. I just changed the input b to d. The other b (the one it the structure) is just short for the word branch btw.

[claudiu]

*facepalm*

[QuantumPete]

It's all fixed now thanks. I just changed the input b to d. The other b (the one it the structure) is just short for the word branch btw.

That's not fixed. That's masking the problem. Like Salem said, use proper variable names and you wouldn't have had this problem in the first place.