Conversion problem not working properly

Hi All,

I have written a program to input a decimal string and convert it to character string. Below is my program:

Code:

/*this program converts the decimal representation of an input string to character representation*/
#include<math.h>
#include<stdio.h>
#include<stdlib.h>
char int2str(int n);
int main()
{
int dec[100]={0},i,j,decindex,ndec=0,nchar;
char character[100]={'\0'};
printf("Enter the input decimal sequence length\n");
scanf("%d",&ndec);
printf("Enter the input decimal sequence\n");
for(i=0;i<=nchar;i++)
{
     scanf("%d",&j);
     dec[i]=j;
}
/*This loop converts the decimal to character*/
for(i=0;i<=nchar;i++)
{    
     if(dec[i]!='.')
     {
     character[i]=int2str(dec[i]);
     }
}
printf("The output sequence is");
for(i=0;i<=nchar;i++)
{
     printf("%c",character[i]);
}
system("pause");
return 0;
}

/*this loop converts the decimal to character*/
char int2str(int n)
{
char c;
c=n+48;
return c;
}

On running the program, It doesn't proceed after entering the input decimal sequence. Kindly point out bugs/errors and suggest fixes. Thank you.

You are assigning value to ndec but using uninitialized value of nchar.

Thank you for your reply. The program still stops at the same point on changing nchar to ndec.

Originally Posted by DRK

You are assigning value to ndec but using uninitialized value of nchar.

> The program still stops at the same point on changing nchar to ndec.
So what does your new indented code look like?

@Salem: Now my code works, but is producing the wrong output.
For example if I enter the input sequence length as 4 and input 1,9,.,8 one by one, my code gives me output as 1999 whereas It should give 19.8 in character representation.

Below is my indented code:

Code:

/*this program converts the input decimal representation to character string representation*/
#include<math.h>
#include<stdio.h>
#include<stdlib.h>
char int2str(int n);
int main()
{
int dec[100]={0},i,ndec=0,no;
/*dec[100] contains the input decimal sequence, i is used for indexing,ndec for storing the number of digits in
the input decimal number*/
char character[100]={'\0'};
printf("Enter the input decimal sequence length\n");
scanf("%d",&ndec);
printf("Enter the input decimal sequence\n");
/*This loop inputs the decimal sequence*/
            for(i=0;i<ndec;i++)
                   {
                          scanf("%d",&no);
                          dec[i]=no;
                   }
/*This loop converts the decimal to character*/
            for(i=0;i<ndec;i++)
                   {  
                      if(dec[i]!='.')
                      {  
                          character[i]=int2str(dec[i]);
                      }
                      else
                      {
                          character[i]=dec[i];
                      }   
                   }
/*This loop outputs the sequence*/
printf("The output sequence is");
            for(i=0;i<ndec;i++)
                   {
                   printf("%c",character[i]);
                   }
system("pause");
return 0;
}
/*This function converts integer to character representation and returns it to the main function*/
char int2str(int n)
     {
                   char c;
                   c=n+48;
                   return c;
     }

Please point out the errors. Thank you.

Originally Posted by Salem

> The program still stops at the same point on changing nchar to ndec.
So what does your new indented code look like?

O_o

I'm not sure what this is even supposed to do.

You are using `scanf' (a formatted input function) so one can safely assume the input is already in a character representation.

The function `int2str' does not do what it says on the label; at best it is `intplus48convertedtochar'. You shouldn't use "magic numbers" and because this is unfiltered input shouldn't be making assumption about the value of `n'.

Soma

The question is:

Write a program to convert a decimal representation for a number to the corresponding character string representation.

I am using scanf %d representation to input decimal number and store it in dec[i] array.

Since the input number is in decimal representation, the character equivalent will be int+48. For example, if 2 is entered, 2+48=50 is 2 in char, that is what I intend to achieve using the 'int2str' function.

As far as filtering of input decimal number is concerned, the user only enters values between 0-9. However, If a user enters a '.' point, then it is filtered using the following part of the program:

Code:

if(dec[i]!='.')                      {  
                          character[i]=int2str(dec[i]);
                      }
                      else
                      {
                          character[i]=dec[i];
                      }

Originally Posted by phantomotap

O_o

I'm not sure what this is even supposed to do.

You are using `scanf' (a formatted input function) so one can safely assume the input is already in a character representation.

The function `int2str' does not do what it says on the label; at best it is `intplus48convertedtochar'. You shouldn't use "magic numbers" and because this is unfiltered input shouldn't be making assumption about the value of `n'.

Soma

2+48=50 is 2 in char

No.

2+48=50 is '2' in ASCII

That's kind of an important difference.

the user only enters values between 0-9

My point was that you've done nothing to ensure that.

O_o

So... your task is to take input in the form of:

Code:

12 1 2 3 4 5 6 7 8 9 8 7 6

and turn it into:

Code:

"123456789876"

?

That seems especially pointless even for early example work.

In any event, you've said that '.' is valid input; you've also said that the user enters only integer values between zero and nine.

These things do not get along. I'll point you to the documentation for `scanf' and "%d" format string.

Soma

No.

That's kind of an important difference.

Thank you for your detailed reply.

I am sorry for that obvious error, I meant if a user enters an ASCII decimal input he gets an ASCII character output.

So... your task is to take input in the form of:

Code:

12 1 2 3 4 5 6 7 8 9 8 7 6

and turn it into:

Code:

"123456789876"

In essence, user has the choice to enter 12.43 in the sequence 1 2 . 4 3 (number of input digits ndec=5) individually or 12 . 43 (number of input digits ndec=3), either way my program should give 12.43 in ASCII character representation, I think that is what the question wants me to do.

In any event, you've said that '.' is valid input; you've also said that the user enters only integer values between zero and nine.

The user enters value between 0-9 including a decimal point '.'

I have changed my program to accommodate '.'

These things do not get along. I'll point you to the documentation for `scanf' and "%d" format string.

I don't understand how a decimal point '.' is represented, ASCII table doesn't have a decimal equivalent for '.'

Only the character equivalent of decimal 46 represents a '.' in ASCII