Always give me wrong answer

**amroto** · 03-29-2012

Hi , guys i have problem to solve this i write the code and didn't give any error but give me wrong answer when i run the program

This is the problem:
Write a program that prompts user to enter an integer number and determines whether it is
even or odd , whether it is divisible by 5 and 7 , whether it is divisible by 5 or 7 , whether it is
divisible by 5 or 7 , but not both .

This is the code i write

Code:

#include<stdio.h>
void main()
{
    int num = 0 , remainder = 0;
    int num1 = 0 , num2 = 0;
    printf("please Enter an integer number:");
    scanf("%d" , &num);
    {
remainder = num %2;
    if (remainder==0)
    printf("%d is Even number \n " ,num);
    else
printf("%d is Odd number \n " ,num);
}

    {
num1 = num %5;
num2 = num %7;
{
if((num1==0) && (num2==0))
printf("%d true \n");
else
printf("%d false \n");
}
{
if((num=1==0) || (num2==0))
printf("%d true \n");
else
printf("%d false \n");
}
{
if(((num1==0) || (num2==0)) && ((num1==0) && (num2==0)))
printf("%d true \n");
else
printf("%d false \n");
}
    }
}

**msh** · 03-29-2012

Please reformat your code before we proceed. People here, and that includes me, get very annoyed when we want to help someone and they're making it hard for us to. It's akin to saving a panicking drowning person.

**ledow** · 03-29-2012

Seeing as you've totally ignored all the compiler warnings also, I won't bother to mention them in detail. Hint: EVERY Printf being wrong? Really?

Also, you have glaring errors, like:

Code:

if((num=1==0) || (num2==0))

(stray ='s in the middle of num and 1)

and the last if? WTH is that trying to do?

Code:

if(((num1==0) || (num2==0)) && ((num1==0) && (num2==0)))

**claudiu** · 03-29-2012

No offence mate, but not everything you barf in an editor is code. I mean how can you post here and ask for questions without having compiled it at least once. There are so many wrong things with that code that even a child will be able to fix at least one or two very very very OBVIOUS ones.

**MK27** · 03-29-2012

Originally Posted by amroto

Write a program that prompts user to enter an integer number and determines whether it is
even or odd , whether it is divisible by 5 and 7 , whether it is divisible by 5 or 7 , whether it is
divisible by 5 or 7 , but not both .

And I bet what you did is write all of the code to do that, figuring once it was finished you could try it out then go back and fix whatever appeared to be wrong.

That is a common enough beginner mistake, but it is not how you program. You program by breaking a task down into smaller parts and coding one section at a time in such a way that you can compile and test it, because you actually need to compile and test it, making sure it works the way you want it to before you move on. This may mean you have to temporarily shim something in to do the test (eg, for the first bit, getting an input, you will want a temporary printf to check if the input is correct). One reason it is stupid and a waste of time to do anything else is because if you are wrong about how the first thing works and everything after that is based on an incorrect assumption, everything else may be garbage once you fix the first part. Another is that you are likely to repeat the same basic mistake over and over again, as you did with the printfs.

It looks to me like you do have the first two bits of this correct enough, ie, getting an input and determining if it is odd or even. Everything after that is wrong, so scrap it, and try to code just the next bit ("whether it is divisible by 5 and 7"). When that works, you can move on.

And do take seriously msh and ledow's comments about:
a) correctly formatting (indenting) code.
b) turning on and paying attention to compiler warnings.
If you can't do that, most people here will not entertain you for long.

**amroto** · 03-29-2012

Originally Posted by msh

Please reformat your code before we proceed. People here, and that includes me, get very annoyed when we want to help someone and they're making it hard for us to. It's akin to saving a panicking drowning person.

sorry my friend but really i dont understadand what you mean because my weak english language but if mean what is the language i use ,so i use C-language

**amroto** · 03-29-2012

Originally Posted by ledow

Seeing as you've totally ignored all the compiler warnings also, I won't bother to mention them in detail. Hint: EVERY Printf being wrong? Really?

Also, you have glaring errors, like:

Code:

if((num=1==0) || (num2==0))

(stray ='s in the middle of num and 1)

and the last if? WTH is that trying to do?

Code:

if(((num1==0) || (num2==0)) && ((num1==0) && (num2==0)))

Thank you i didn't notice that , and yes now the program run well and give me right answer

**MK27** · 03-29-2012

Originally Posted by amroto

sorry my friend but really i dont understadand what you mean because my weak english language but if mean what is the language i use ,so i use C-language

S/he means this:

Indent style - Wikipedia, the free encyclopedia

This is very important, particularly if you want other people to read and understand your code.

**amroto** · 03-29-2012

thanks for all who cares about my topic and try to learn me something new

Thread: Always give me wrong answer

Thread Tools

Search Thread

Display

Always give me wrong answer

Similar Threads

Pls give me the answer

please help stuck on a slight problem, basic, easy to read, getting wrong answer

Wrong answer?

Question 26 Answer seems wrong on site quiz

wrong answer?