Thread: creating functions

i want to make the menu in this program a function so it will be at the bottom and you simply call it without it being in the main. I tried but when i did it didnt like the way i returned it to the switch...

Code:

#include<stdio.h>
#include<stdlib.h>
int genrand()
{
    int random;
    random = 1+rand() % 999 ;
    while(random==0)random= 1+rand() % 999 ;
    return random;
}
void main()
{
    srand (time(NULL));
    int a,ary[50],random;
    for(random=0;random<50;random++)
    {
        ary[random]='\0';
    }
    while(1)
    {
        printf("\n***************************************");
        printf("\n                MENU                   ");
        printf("\n1. Fill array with random numbers      ");
        printf("\n2. Print the array                     ");
        printf("\n3. Search the array                    ");
        printf("\n4. Sort the array                      ");
        printf("\n5. Quit                                ");
        printf("\n***************************************\n");
        scanf("%d",&a);
        switch(a)
        {
            case 1:
            {
                for(random=0;random<50;random++)
                {
                    ary[random]=genrand();
                }
                break;
            }
            case 2:
            {
                for(random=0;random<50;random++)
                {
                    printf("%d   ",ary[random]);
                }
                break;
            }
            case 3:
            {
                int n,c=0;
                printf("\nEnter search number: ");
                scanf("%d",&n);
                for(random=0;random<50;random++)
                {
                    if(ary[random]==n){
                        printf("\nNumber is at position(s): %d",(random+1));
                        c=1;
                    }
                }
                if(c==0)printf("\nNumber doesn't exist.");
                break;
            }
            case 4:
            {
                int i;
                int x;
                int y;


                for(i=0;i<50;i++)
                {
                    for(x=0;x<49;x++)
                    {
                        if(ary[x]>=ary[x+1])
                        {
                            y=ary[x];
                            ary[x]=ary[x+1];
                            ary[x+1]=y;
                        }
                    }
                }
                break;
            }
            case 5:
            {
                exit(0);
            }
            default:
            {
                printf("\nINVALID CHOICE: ");
            }
        }
    }
}

Code:

#include<stdio.h>
#include<stdlib.h>
int genrand()




{
    int menu(void);
    int random;
    random = 1+rand() % 999 ;
    while(random==0)random= 1+rand() % 999 ;
    return random;
}
void main()
{
    srand (time(NULL));


    int a;
    int ary[50];
    int random;


    for(random=0;random<50;random++)
    {
        ary[random]='\0';
    }
    while(1)
    {


        menu()=switch(a)
        {
            case 1:
            {
                for(random=0;random<50;random++)
                {
                    ary[random]=genrand();
                }
                break;
            }
            case 2:
            {
                for(random=0;random<50;random++)
                {
                    printf("%d   ",ary[random]);
                }
                break;
            }
            case 3:
            {
                int x;
                int y=0;
                printf("\nEnter search number: ");
                scanf("%d",&x);
                for(random=0;random<50;random++)
                {
                    if(ary[random]==x){
                        printf("\nNumber is at position(s): %d",(random+1));
                        y=1;
                    }
                }
                if(y==0)printf("\nNumber doesn't exist.");
                break;
            }
            case 4:
            {
                int i;
                int x;
                int y;


                for(i=0;i<50;i++)
                {
                    for(x=0;x<49;x++)
                    {
                        if(ary[x]>=ary[x+1])
                        {
                            y=ary[x];
                            ary[x]=ary[x+1];
                            ary[x+1]=y;
                        }
                    }
                }
                break;
            }
            case 5:
            {
                exit(0);
            }
            default:
            {
                printf("\nINVALID CHOICE: ");
            }
        }
    }
}


int menu(void)
{
    int a;


    printf("\n***************************************");
    printf("\n                MENU                   ");
    printf("\n1. Fill array with random numbers      ");
    printf("\n2. Print the array                     ");
    printf("\n3. Search the array                    ");
    printf("\n4. Sort the array                      ");
    printf("\n5. Quit                                ");
    printf("\n***************************************\n");
    scanf("%d",&a);
    return a;
}

ok thanks,
i originally had the int menu(void) up a few lines out of the function but it says "declaration for parameter 'menu' but no such parameter but when i have it where within the function, it runs.

anything else that i could improve upon in this code? trying to be a "good" programmer not just one that can put stuff together and hope it works