This should not give me a seg fault. Yet.....it does.

[cjavier]

#include <stdio.h>
#include <string.h>
char* strconcatenate(char *to, const char *from);
int main()
{


   char* hello= "Hello ";
   const char* world= "World!";
   fprintf(stderr, "%s\n", strconcatenate(hello, world));
   return 0;
}




char* strconcatenate(char *to, const char *from)
{
   while((*to) != '\0')
   {
      printf("Execute\n");
      to++;
   }
   while((*from) != '\0')
   {
      printf("Execute2\n");
      *to++ = *from++;
   }
   *to = 0;
   printf("Gotcha\n");
   return to;
}

[cjavier]

It will print execute 2 once and that's it. WHYYYYY????!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!

[dmh2000]

you don't have room in your 'to' string for the extra characters so it is overrunning. change the declaration of hello to char hello[MAX SIZE YOU EXPECT] = "Hello";

[Elkvis]

what makes you think that this "should not" give you a seg fault? you're not allocating any space for the string you're adding to the first.

and try not to use so much punctuation. its serves no purpose. we understand that you are confused, and the excessive punctuation is unpleasant to look at, and makes you look like a n00b.

[oogabooga]

And the string literal "Hello " may be stored in memory that you're not allowed to write to.