Thread: C Program - Creating a table with squared and cubed results from user inputs

I am supposed to write a C program with a function selectTable that accepts values for numbers, tablesize, and increment in which the numbers increase by and produce a table with those inputs. What am I doing wrong?

Code:

#include<stdio.h>
#include<stdlib.h>
#pragmawarning (disable:4996)
int main()
{
  void selectTable(float, float, float);
  float tablesize, numbers, increment;
  printf("Ener the table size: ");
  scanf("%f", &tablesize);
  printf("Enter the number to begin with: ");
  scanf("%f", &numbers);
  printf("Enter the increment the numbers will increase by: ");
  scanf("%f", &increment);
  selectTable(numbers, tablesize, increment);
  system("pause");
  return 0;
}

void selectTable(float numbers, float tablesize, float increment)
{
  int i;
  printf("NUMBER SQUARE CUBE \n");
  printf("------ ------ ---- \n");
  　i = 0;
  for (numbers; numbers += increment;)
    for (i = numbers; i <= (numbers + (tablesize - 1) * increment);
         i += increment);
  printf("%f %f %f\n", numbers, numbers * numbers,
         numbers * numbers * numbers);
}

Remove the ; at the end of line 27
You have loops which do nothing,

Well you could fix one of your for loops to actually have an exit condition.

Originally Posted by LearnOnTheFly

I am just beginning in C, how would I write an exit condition.

Compare the one without a proper exit condition:

Code:

for (numbers; numbers += increment;)

with one that does:

Code:

for (i = numbers; i <= (numbers + (tablesize - 1) * increment); i += increment);

Basically, numbers += increment became your exit condition, and unless numbers ever evaluates to 0 (false), you have an infinite loop.

What is your current code, and how does it not work?

That's because you're not printing a number that changes within the loop. I think you mean to do

Code:

      printf("%f %f %f\n", i, i*i, i*i*i);

although even this will have a few issues when you try to compile it.

That's right. You could also change "i" to a float. That might actually be better, because you're prompting the user for floats.