Thread: trim last character of a string

Code:

#include <stdio.h>


char* LastcharDel(char* name);

int main ()
{
	// declarations
	char name[20];

	printf("Enter your name:\n");
	scanf("%s", name);

	// fucntion calls
	LastcharDel(name);

	printf(" your name without last character : %s\n\n", name);

	return 0;
}

char* LastcharDel(char* name)
{
	int i = 0;
	for(i =0; i< 20; i++)
	{
	if(i > 1)
    name[i- 1] = '\0';
	}

	return name;
}

how do i do this problem? the problem require to write a function that accepts a string (a pointer to a character) and deletes the last character by moving the null character one position to the left.

Also write a main function that inputs your family name, calls this function, and then ourputs your family name after the call (it should be missing the last letter at this point). Copy your code and the output (as a comment at the bottom of the code) as run by entering your name.

the code above is what i got so far

What do you mean? Your code works fine for me. Here is what I get when I compile/run your code:

Code:

$ gcc -Wall -g -std=c99  trim.c   -o trim
$ ./trim
Enter your name:
Smith
 your name without last character : Smit

Does your console window disappear before you can read the output perhaps?

yes my console disappear before i can read the output

may be i need to use a system "pause"

Hooray for self-reliance!

yes my console disappear before i can read the output

Read this link: FAQ > Stop my Windows Console from disappearing everytime I run my program? - Cprogramming.com.

Originally Posted by khoavo123

i still have a question about this though

can any one interpret this because it kinda confusing
Also write a main function that inputs your family name, calls this function

what does that mean?

You already did this:
write a main funciton

Code:

int main()
{
    ...
    return 0;
}

that inputs your family name

Code:

printf("Enter your name:\n");
scanf("%s", name);

calls this (the delete last char) function

Code:

// fucntion calls
LastcharDel(name);

If all you want to do is get rid of the last character in the string, you don't need to have anything in a loop.
Since this string is statically allocated, there is no guarantee that it will be filled by whatever the user fills
This is the easiest way I could think of

Code:

#include <stdio.h>
#include <stdlib.h>
#include <string.h>

void lastCharDel (char *name);

int main (void)
{
    char name[20];
    
    printf("Enter your name:\n");
    scanf("%s", name);
    lastCharDel(name);
    printf("your name without last character : %s\n\n", name);
    system("pause");
    return 0;   
}

void lastCharDel (char *name)
{
     int length;
     length = strlen(name);//Get length of string
     name[length - 1] = '\0';//Set next to last char to null
     return;
}

Hope this helps