Problem with calling functions

[SaraDawkins]

I made this program that is supposed to calculate conversions and pass the data back. Although it compiles, when I run it, it spews random incorrect data for the converted values. Please help.

#include <stdio.h>
    
void getInput(int* fahrenheit, int* pounds, int* feet);
void calc(int fahrenheit, int pounds, int feet, double* celsius, double*
          meters, double* kilograms);
double calcTemp(int fahrenheit, double* celsius);
double calcDistance(int feet, double* meters);
double calcWeight(int pounds, double* kilograms);
void display(int fahrenheit, int pounds, int feet, double celsius,
             double kilograms, double meters);
   
int main(void)
{
   int fahrenheit, pounds, feet;
   double celsius, kilograms, meters;


 
      getInput(&fahrenheit, &pounds, &feet);
      calc(fahrenheit, pounds, feet, &celsius, &kilograms, &meters);
      display(fahrenheit, pounds, feet, celsius, kilograms, meters);


   return 0;
}
 
void getInput(int* fahrenheit, int* pounds, int* feet)
{
    printf("\nPlease enter temeperature in Fahrenheit (integer): ");
    scanf("%d", &fahrenheit);
    printf("\nPlease enter a distance in feet (integer): ");
    scanf("%d", &feet);
    printf("\nPlease enter a weight in pounds (integer): ");
    scanf("%d", &pounds);
}
   
void calc(int fahrenheit, int pounds, int feet, double* celsius, double*
          meters, double* kilograms)
{
   calcTemp(fahrenheit, celsius);
   calcDistance(feet, meters);
   calcWeight(pounds, kilograms);
}


double calcTemp(int fahrenheit, double* celsius)
{
   *celsius = (fahrenheit -32) * (float)5/9;
}


double calcDistance(int feet, double* meters)
{
   *meters = (float)feet * 0.3048;
}


double calcWeight(int pounds, double* kilograms)
{
 *kilograms = (float)pounds * 0.45359237;
}
    
void display(int fahrenheit, int pounds, int feet, double celsius, double
             kilograms, double meters)
{
   printf("\n%15s%15s%15s%15s", "Original", "Value", "Converted to", "Value");
   printf("\n%15s%15s%15s%15s", "-----------", "-----", "------------", "-----"$
   printf("\n%15s%15d%15s%15f", "Fahrenheit", fahrenheit, "Celsius", celsius);
   printf("\n%15s%15d%15s%15f", "Feet", feet, "Meters", meters);
   printf("\n%15s%15d%15s%15f", "Pounds", pounds, "Kilograms", kilograms);
}

[stahta01]

The fahrenheit, pounds, feet are already pointers you do NOT need to get the address of them to use with scanf.
Tim S.

void getInput(int* fahrenheit, int* pounds, int* feet)
{
    printf("\nPlease enter temeperature in Fahrenheit (integer): ");
    scanf("%d", &fahrenheit);
    printf("\nPlease enter a distance in feet (integer): ");
    scanf("%d", &feet);
    printf("\nPlease enter a weight in pounds (integer): ");
    scanf("%d", &pounds);
}

[nonoob]

Also your three conversion functions should be type void because they do not return anything.

void calcTemp(int fahrenheit, double* celsius); 
void calcDistance(int feet, double* meters); 
void calcWeight(int pounds, double* kilograms);

[SaraDawkins]

Thanks so much, that fixed my initial problem! Now however I'm trying to add another conversion, from celsius to kelvin. When I try to compile I am getting the error, "invalid operands to binary +". Any help is much appreciated, I am new to coding and it is a little frustrating.

#include <stdio.h>

void getInput(int* fahrenheit, int* pounds, int* feet);
void calc(int fahrenheit, int pounds, int feet, double* celsius, double*
          meters, double* kilograms, double* kelvin);
double calcTemp(int fahrenheit, double* celsius, double* kelvin);
double calcDistance(int feet, double* meters);
double calcWeight(int pounds, double* kilograms);
void display(int fahrenheit, int pounds, int feet, double celsius,
             double kilograms, double meters, kelvin);


int main(void)
{
   int fahrenheit, pounds, feet;
   double celsius, kilograms, meters, kelvin;




      getInput(&fahrenheit, &pounds, &feet);
      calc(fahrenheit, pounds, feet, &celsius, &kilograms, &meters,
           &kelvin);
      display(fahrenheit, pounds, feet, celsius, kilograms, meters,
              kelvin);


   return 0;
}


void getInput(int* fahrenheit, int* pounds, int* feet)
{
    printf("\nPlease enter temeperature in Fahrenheit (integer): ");
    scanf("%d", fahrenheit);
    printf("\nPlease enter a distance in feet (integer): ");
    scanf("%d", feet);
    printf("\nPlease enter a weight in pounds (integer): ");
    scanf("%d", pounds);
}


void calc(int fahrenheit, int pounds, int feet, double* celsius, double*
          meters, double* kilograms, double* kelvin)
{
   calcTemp(fahrenheit, celsius, kelvin);
   calcDistance(feet, meters);
   calcWeight(pounds, kilograms);
}


double calcTemp(int fahrenheit, double* celsius, double* kelvin)
{
   *celsius = (fahrenheit -32) * (float)5/9;
   *kelvin = celsius + 273.15;
}


double calcDistance(int feet, double* meters)
{
   *meters = (float)feet * 0.3048;
}
double calcWeight(int pounds, double* kilograms)
{
   *kilograms = (float)pounds * 0.45359237;
}
    
void display(int fahrenheit, int pounds, int feet, double celsius, double
             kilograms, double meters, double kelvin)
{
   printf("\n%15s%15s%15s%15s%15s%15s", "Original", "Value", 
          "Converted to", "Value", "Converted to", "Value");
   printf("\n%15s%15s%15s%15s%15s%15s", "-----------", "-----",
          "------------", "-----", "------------", "-----" );
   printf("\n%15s%15d%15s%15f", "Fahrenheit", fahrenheit, "Celsius",
          celsius, "Kelvin", kelvin);
   printf("\n%15s%15d%15s%15f", "Feet", feet, "Meters", meters);
   printf("\n%15s%15d%15s%15f", "Pounds", pounds, "Kilograms", kilograms);
   printf("\n\n");
}

[rags_to_riches]

Note how you access celsius in the line previous.

[SaraDawkins]

Note how you access celsius in the line previous.

I see that, but I don't see how that is causing a problem. Like I said I am very new to programming.

[Salem]

Getting a decent compiler, and really turning up the warning level will find a lot of newbie mistakes before you even get to run the code.

$ gcc -W -Wall -Wextra bar.c
bar.c:10: error: expected declaration specifiers or ‘...’ before ‘kelvin’
bar.c: In function ‘main’:
bar.c:25: error: too many arguments to function ‘display’
bar.c: In function ‘calcTemp’:
bar.c:55: error: invalid operands to binary + (have ‘double *’ and ‘double’)
bar.c: At top level:
bar.c:68: error: conflicting types for ‘display’
bar.c:9: note: previous declaration of ‘display’ was here
bar.c: In function ‘display’:
bar.c:76: warning: too many arguments for format

It might not seem like it to you at the moment, but getting something to compile in C is exceedingly easy.
The real trick comes later, when you try and make it do what you want.

[nonoob]

You forgot asterisk: *kelvin = *celsius + 273.15;
Also you ignored my help regarding void function type and prototype.

[SaraDawkins]

You forgot asterisk: *kelvin = *celsius + 273.15;
Also you ignored my help regarding void function type and prototype.

Thank you, that seems to have fixed the error, and I didn't ignore your advice, for whatever reason my teacher specified that they should be int and double.

I am now wondering how I would align the values so that the decimal places are lined up.


Ex.)

300.052
112.444
145.676

[SaraDawkins]

Here is my code so far. I have two problems left that I can't figure out:

1. The meters and kilograms values are being swapped when they are displayed.
2. I can't figure out how to align decimals in my display chart.

#include <stdio.h>

void getInput(int* fahrenheit, int* pounds, int* feet);
void calc(int fahrenheit, int pounds, int feet, double* celsius, double*
          meters, double* kilograms, double* kelvin, int* inches);
double calcTemp(int fahrenheit, double* celsius, double* kelvin);
double calcDistance(int feet, double* meters, int* inches);
double calcWeight(int pounds, double* kilograms);
void display(int fahrenheit, int pounds, int feet, double celsius,
             double kilograms, double meters, double kelvin, int inches);


int main(void)
{
   int fahrenheit, pounds, feet, inches;
   double celsius, kilograms, meters, kelvin;




      getInput(&fahrenheit, &pounds, &feet);
      calc(fahrenheit, pounds, feet, &celsius, &kilograms, &meters,
           &kelvin, &inches);
      display(fahrenheit, pounds, feet, celsius, kilograms, meters,
              kelvin, inches);


   return 0;
}


void getInput(int* fahrenheit, int* pounds, int* feet)
{
    printf("\nPlease enter temeperature in Fahrenheit (integer): ");
    scanf("%d", fahrenheit);
    printf("\nPlease enter a distance in feet (integer): ");
    scanf("%d", feet);
    printf("\nPlease enter a weight in pounds (integer): ");
    scanf("%d", pounds);
}


void calc(int fahrenheit, int pounds, int feet, double* celsius, double*
          meters, double* kilograms, double* kelvin, int* inches)
{
   calcTemp(fahrenheit, celsius, kelvin);
   calcDistance(feet, meters, inches);
   calcWeight(pounds, kilograms);
}


double calcTemp(int fahrenheit, double* celsius, double* kelvin)
{
   *celsius = (fahrenheit -32) * (float)5/9;
   *kelvin = *celsius + 273.15;
}


double calcDistance(int feet, double* meters, int* inches)
{
   *meters = (float)feet * 0.3048;
   *inches = feet * 12;
}
    
double calcWeight(int pounds, double* kilograms)
{
*kilograms = (float)pounds * 0.45359237;
}
    
void display(int fahrenheit, int pounds, int feet, double celsius, double
             kilograms, double meters, double kelvin, int inches)
{
   printf("\n%13s%9s%14s%9s%14s%14s", "Original", "Value",
          "Converted to", "Value", "Converted to", "Value");
   printf("\n%13s%9s%14s%9s%14s%14s", "--------", "-----",
          "------------", "-----", "------------", "-----" );
   printf("\n%13s%9d%14s%9.3f%14s%9.3f", "Fahrenheit", fahrenheit,
          "Celsius",celsius, "Kelvin", kelvin);
   printf("\n%13s%9d%14s%9.3f%14s%9d", "Feet", feet, "Meters", meters,
          "Inches", inches);
   printf("\n%13s%9d%14s%9.3f", "Pounds", pounds, "Kilograms",
          kilograms);
   printf("\n\n");
}

[Salem]

void calc(int fahrenheit, int pounds, int feet, double* celsius, double*
          meters, double* kilograms, double* kelvin, int* inches);
////
      calc(fahrenheit, pounds, feet, &celsius, &kilograms, &meters,
           &kelvin, &inches);