gets() skipped!

I try to do linked list for inserting. But when i try the gets(newPtr->name), it never work. It just skip off. Also , the code i posted here are reduced to the most simple + working because it's an assignment and I dont want to be in trouble.

Code:

newPtr = malloc (sizeof(node));  //Create a node with newPtr pointing to it

do{
        //I skip some syntax which is crucial in linked list........<--bcause //it's an assignment

        printf("Name:");
        gets( newPtr -> name);//not working
        printf("Course: ");
        gets( newPtr -> course);
        printf("ID: ");
        scanf("%d", &newPtr -> id);
        printf("Score: ");
        scanf("%f", &newPtr -> score);
        printf("=================================================\n");
        printf("Do you wish to continue? 'S' to STOP:");
        scanf(" %c", &status);
        printf("================================================\n");
    }while(status != 'S'); //continue loop while state is not 'N'

Because scanf leaves the newline in the buffer. Anyway, don't use gets. Use say, fgets instead, to avoid buffer overflow.

Changed. Still no hope...haiz

Code:

newPtr = malloc (sizeof(node));  //Create a node with newPtr pointing to it
 
do{
        //I skip some syntax which is crucial in linked list........<--bcause //it's an assignment
 
        printf("Name:");
        fgets( newPtr -> name,30,stdin);
        printf("Course: ");
       fgets( newPtr -> course,30,stdin);
        printf("ID: ");
        scanf("%d", &newPtr -> id);
        printf("Score: ");
        scanf("%f", &newPtr -> score);
        printf("=================================================\n");
        printf("Do you wish to continue? 'S' to STOP:");
        scanf(" %c", &status);
        printf("================================================\n");
    }while(status != 'S'); //continue loop while state is not 'N'

I already gave you the explanation. Now, time for you to do some debugging, so you'll always remember this. Using your debugger, examine the contents of newPtr->name when you encounter the "skip off". What do you observe?

oo. so that's means u want me to use fgets to get the sentences and wanted to remove the \n character, right.

Using your debugger, examine the contents of newPtr->name when you encounter the "skip off". What do you observe?

it already got input earlier than the next one. (probably \n) character.

you can write the following function and call it before calling the gets function.

Code:

clear_input_buffer();
gets(string);

The function clear_input_buffer is as follows:

Code:

int clear_input_buffer(void)
{
	int ch;
	while(((ch=getchar())!=EOF) && (ch != '\n'));
	return ch;
}

I try this . Anyway still no hope.

Code:

while(tempChar = getchar() != '\n'){
            newPtr -> name[i++] = tempChar;
 }
        newPtr -> name[i++] = '\0';

aw still not working even with scanf. I try many many alternate way but it's still not working.

Code:

  do{
            scanf("%c", newPtr -> name[i]);
            i++;
        }while(newPtr -> name !='\n');

Originally Posted by kappilrinesh

you can write the following function and call it before calling the gets function.

Don't use gets! Why do you insist on it when laserlight explicitly mentioned that it should not be used?

ncode, the idea here is that you call clear_input_buffer before your scanf statements. You did use the debugger, right? You understand the issue, right?

Originally Posted by Elysia

ncode, the idea here is that you call clear_input_buffer before your scanf statements. You did use the debugger, right? You understand the issue, right?

That would be bad, you'd end up consuming valid input since the problem shows up after scanf executes and is followed up with gets (or fgets).

The scanf function leaves any input it did not scan in for other functions to get. The gets function follows its own rules. It stores input in the argument until the newline character is read, and it is disposed of. If there is stuff in the buffer for gets to read in, then the user doesn't have an opportunity to type.

The fix is to follow up scanf calls with anything that discards input. Further reading can be found here.

Are you Linux? You never specified. if so:

Code:

system("/bin/stty raw");
        selection=getchar();
        system("/bin/stty cooked");

Use one mor gets at the and of the loop
for example i use always this

Code:

char error[50];
char surname[25];
char name[20];
int id;

while(1) //this is an example
{ 
  printf... enter name;
  gets(name);
 
  printf... enter surname;
 gets(surname);

printf...enter id;
scanf("%d",&id);

gets(error); //this will copy the id value(you dont have to enter any value). if you dont put this, in the next time of looping, name will be skipped.
}

....

i never used fgets etc. dont know how it works, i used it only at file openings.

Originally Posted by rac1

Use one mor gets at the and of the loop

No! Don't use gets!

i never used fgets etc. dont know how it works, i used it only at file openings.

Not a valid excuse. Go learn it and come back, then.
Stop teaching newbies bad practices.

if it works no problem doesn't it?
yes works...

It works no problem?

Code:

#include <stdio.h>
struct foo {
   char s1[5];
   char s2[5];
};

int main(void) 
{
   struct foo bar = { "" , "" };
   gets(bar.s1);
   printf(" s1 = \"%s\"\n s2 = \"%s\"\n", bar.s1, bar.s2);
   return 0;
} 

/*
C:\Documents and Settings\User>a
12345678
 s1 = "12345678"
 s2 = "678"
*/

Clearly this is just flawless... why was s2 allowed to be changed?

fgets is not rocket science:

Code:

 resultptr = fgets( storage, howmanycharacters, fromfile );

It's easy to use and safe, please figure it out or just stop using C...