Search command output for string

Hi,

I'm very new to C programming.

What I'm attempting to do is to run a command in Windows and then parse the output of that command for a specific string of characters. Here is the code that I have working--it simply prints the output of the command.

Code:

---

#include <stdio.h>

int main()
{
    FILE *fp;
    char path[1035]; // Set path array size to 1035.


    fp = popen("ipconfig", "r"); // Open the command.
    if(fp == NULL) { // If nothing is returned, error out.
        printf("Failed to run command\n");
    }


    while(fgets(path, sizeof(path) - 1, fp) != NULL) { // Get output from command and print it.
        printf("%s", path);
    }


    pclose(fp);


    return 0;
}

---

What I'd like this program to do is parse the output of that command (rather than print it), searching for specific IP addresses. If it finds the searched-for IP address(es), I would like it to print those values. As yet, I have been unable to do this.

Any pointers would be greatly appreciated!

~ Tom

Look up strcmp() and strstr() to begin with.

Quote:

---

Originally Posted by Salem

Look up strcmp() and strstr() to begin with.

---

Thanks Salem! Looks like strstr was what I needed! I had tried strcmp previously but was unable to get it to return the value I was looking for.

Here's what I came up with:

Code:

---

#include <stdio.h>


int main()
{
    FILE *fp;
    char path[1035]; // Set path array size to 1035.


    fp = popen("ipconfig", "r"); // Open the command.
    if(fp == NULL) { // If nothing is returned, error out.
        printf("Failed to run command\n");
    }


    while(fgets(path, sizeof(path) - 1, fp) != NULL) { // Get output from command and print it.
        //printf("%s", path);


        // Search for our substrings
        const char *lgString = path;
        const char *smString = "IPv4";
        char *ptr;
        ptr = strstr(lgString, smString);


        if(ptr) { // If found, filter out relevent strings by IP
            const char *lgString2 = ptr;
            const char *smString2 = "xxx.xxx.xxx";
            char *ptr2;
            ptr2 = strstr(lgString2, smString2);


            if(ptr2) { // If found, print the resulting IP.
                printf("Your IP address is: %s", ptr2);
            }
        }
    }


    pclose(fp);
    return 0;
}

---

So this works to give me the value that I'm looking for. But is there possibly a better way to do this (overall, not just regarding the while loop)? (Better meaning more efficient, cleaner, or whatnot.)

As I mentioned, I'm new to C and always interested in seeing someone else's take on how to solve a particular problem. So if you're open to providing your feedback, I'd love to hear it!

Thanks again!

~ Tom

Don't include comments like "set path array size to 1035" since the code is obvious.
You should exit with some non-zero value if the file doesn't open.
Don't say "our" in your comments (since I had nothing to do with it).
You don't need the -1 after sizeof(path). fgets knows it needs to save a character for the terminating null.
You don't need the extra variables lgString, smString. They just clutter things up.

Quote:

---

Originally Posted by oogabooga

Don't say "our" in your comments (since I had nothing to do with it).

---

The award for Dumbest Nit Pick of the Day goes to ... YOU!


Quzah.

Quote:

---

Originally Posted by quzah

The award for Dumbest Nit Pick of the Day goes to ... YOU!

---

Awesome! Thanks!
It's a pet peeve of mine to see the pretentious "our" in comments.

Quote:

---

Originally Posted by oogabooga

Don't say "our" in your comments (since I had nothing to do with it).

---

"Our" wasn't referencing YOU and me--the ideas I'm using to experiment with C have already been put to use in some scripts that I've created for my employer. So "our" more generally refers to anyone (who works for my employer) who might run this program or view the code.

Thanks for the feedback, though! I'll keep your other suggestions in mind. :-)