Can anyone help me debug this problem?

[Chua]

#include <stdio.h>#include <conio.h>
#include <ctype.h>
#include <string.h>
#define LENGTH 20
 
int main()
{
     
    char s[LENGTH] = {'\0'};
    char number[10] = {'\0'};
    char operation[10]= {'\0'};
         
    /* read in the users data and ends by enter */
 
    printf("enter mathematical term: \n");
 
    gets(s);
 
 
    printf("printing s\n");
    for (int i=0 ; i<LENGTH ; i++)
    {
        printf("%c" , s[i]);    
    }
    printf("\n");
 
    /*  initializing arrays  */
 
    int k=0,l=0;
 
    for (int j=0 ; j<LENGTH ; j++){
        if (('0'<= s[j]) && (s[j]<= '9'))
        {
 
            number[k] = s[j];
            printf("%c\n" , s[j] ); //to see 
            k++;
        }
                 
 
        else
        {       
         
            operation[l]=s[j];
            l++;
        }
    }
 
    /*  preview arrays  */
 
     printf("printing number\n");
    for (int m=0 ; m<10; m++)
        printf("%c" , number[m]);
 
    printf("\n");
 
    printf("printing operation\n");
    for (int n=0; n<10; n++)
        printf("%c" , operation[n]);
 
    printf("\n");
 
     
    return(0);
}

why is there a debugging error?

[FloridaJo]

First, get rid of conio.h and never look at it again.
Second, this is wrong:
if (('0'<= s[j]) && (s[j]<= '9'))

Fix that, try again, and what is your error?

[Chua]

so how do i change if (('0'<= s[j]) && (s[j]<= '9')) so that it will be right?

[nonoob]

This is OK: if (('0'<= s[j]) && (s[j]<= '9'))
Your LENGTH is 20 yet your arrays are only 10 elements. So you are overrunning the array number[]

[memcpy]

How does your compiler not warn you against using gets()? If you decide to enter something that's longer than twenty characters, it will silently corrupt the stack memory following your variable until it segfaults or reaches the end of your input.

Unless you're dealing with unprintable characters, it seems pointless to have for loops of which their sole function is to print out a string. If you are, why are you declaring three different 4-byte ints for counting? A single short at the beginning would be sufficient for all of the loops, as the first part in a for loop can be used to zero the counter. Otherwise, just use

printf("%s", var);

like everyone else.

[BillyTKid]

If you includes ctype.h you can use isdigit instead of your wrong line 32.