Thread: pointer from integer without a cast - warning

Hi,

Could you please help me with my problem?

I have the following structure:

Code:

static struct device_t * dev;
int err = close(dev);
        if (err != 0)
        {
            LOGE(err, "couldn't close device (%s)", strerror(-err));
         }
LOGD("Close device OK");

The warning: "passing argument 3 of '__android_log_print' makes pointer from integer without a cast" is shown at

Code:

LOGE(err, "couldn't close device (%s)", strerror(-err));

Thank you.

As far as I understand from reading documentation, strerror returns an address to a string. Seems your compiler warning sees it returning an integer.
Did you remember to include
#include <string.h> // for strerror()

@itsme86: should I have used instead LOGE_IF()? I'm passing -err to strerror, because I want to print the real error message
@nonoob: actually, I haven't included #include <string.h>.

But I also get the same error when trying the following:
#include <string.h>
.....
char *value;
value=get_val("FORMAT");
....
where get_val is declared as: int get_val(char *variable); and "FORMAT" is declared by the user

What can be so wrong that this error keeps popping out?

Thank you.

Originally Posted by Andreea Coman

char *value;
value=get_val("FORMAT");
....
where get_val is declared as: int get_val(char *variable); and "FORMAT" is declared by the user

What can be so wrong that this error keeps popping out?

Well, your function returns an int and you're trying to assign it to a char *.

About the second issue:
@anduril462: but if I have several strings declared by the user, such as "ROTATION" or "HEIGHT" which take integer values, then how could I use the same get_val function for them and for "FORMAT" (which takes char values)?

Thank you.

Originally Posted by Andreea Coman

@itsme86: should I have used instead LOGE_IF()? I'm passing -err to strerror, because I want to print the real error message
@nonoob: actually, I haven't included #include <string.h>.

err will always be -1 on error and will more than likely your error will not be 1. Have a look at close and see that it sets errno.
also close takes an int argument not a struct device_t *.

Code:

NAME
       close - close a file descriptor

SYNOPSIS
       #include <unistd.h>

       int close(int fd);

DESCRIPTION
       close()  closes  a  file descriptor, so that it no longer refers to any
       file and may be reused.  Any record locks (see fcntl(2))  held  on  the
       file  it  was  associated  with,  and owned by the process, are removed
       (regardless of the file descriptor that was used to obtain the lock).

       If fd is the last copy of a particular file  descriptor  the  resources
       associated  with it are freed; if the descriptor was the last reference
       to a file which has been removed using unlink(2) the file is deleted.

RETURN VALUE
       close() returns zero on success.  On error, -1 is returned,  and  errno
       is set appropriately.

@sparkomemphis:
Actually my close is defined by the user as being something like:
static inline int close(struct device_t* device);

Sorry for not mentioning it before !!

Originally Posted by Andreea Coman

@sparkomemphis:
Actually my close is defined by the user as being something like:
static inline int close(struct device_t* device);

Sorry for not mentioning it before !!

That's not a good idea since there is already a function called closed that is needed to close files. Depending up on the OS and linker you may be one or the other.

@sparkomemphis:
I have renamed the close() function into my_close(), and still get the same error

Have you defined LOGE someplace? As prototype or perhaps you are missing another #include for its header.

@nonoob: I have used LOGE simple in a format like: LOGE("Can't open this !"); and no errors appeared, so I'm guessing it's something wrong with the pointer-integer issue. I will try what itsme86 suggested and let you know.

Any suggestions for the same error, but problem no.2? :-s

Thanks guys

Originally Posted by Andreea Coman

@anduril462: but if I have several strings declared by the user, such as "ROTATION" or "HEIGHT" which take integer values, then how could I use the same get_val function for them and for "FORMAT" (which takes char values)?

Do you have some sort of key-value pair, where "FORMAT" may correspond to a value of "foo" and "HEIGHT" may correspond to a value of "3"? Then you need to either make a functions called get_int_val and get_str_val, or you need to make get_val return the char * version of the data and use a function like strtol to convert the result of get_val to a long if it's supposed to be a number.