Hi,
I am trying to use an operator += for the folowing code, but it dose not works:
The result with this code is, de client receives the list of the last file in that directory. InstedCode:DIR *dp; struct dirent *ep; char *serverlist = ""; dp = opendir ("./"); if (dp != NULL){ while (ep = readdir (dp)) serverlist = ep->d_name; (void) closedir (dp);i want to useCode:serverlist = ep->d_name;to link string. My question is, how can i achive this?Code:serverlist += ep->d_name;
thanks,
alix
Do you want strcat(serverlist, ep->d_name) ? You can't concatenate strings in C with + or +=.
hi oogabooga,
i searcht for what strcat means and indeed that what i want to achieveSo changed it to strcat, but stil same problems:strcat = "The strcat() function concatenates str2 onto the end of str1, and returns str1."
but this way the application crashesCode:DIR *dp; struct dirent *ep; char *serverlist = ""; dp = opendir ("./"); if (dp != NULL){ while (ep = readdir (dp)) strcat(serverlist,ep->d_name); (void) closedir (dp); rv = send(s, serverlist, strlen(serverlist), 0); } else perror ("Couldn't open the directory"); stop_received = 1;
Last edited by Alix; 01-08-2012 at 12:56 PM.
You're not allocating serverlist to anything, it's an empty string literal.
Use a malloc() on serverlist before trying to modify its contents.
Because serverlist isn't a char array you can append an arbitrary amount of data to.
would be a start, but again would blow up for large directories.Code:char serverlist[10000]; serverlist[0] = '\0';
Or you could just do the send in the loop, and the whole "allocate a large buffer" problem goes away.
Code:while (ep = readdir (dp)) rv = send(s, ep->d_name, strlen(ep->d_name), 0); (void) closedir (dp);
If you dance barefoot on the broken glass of undefined behaviour, you've got to expect the occasional cut.
If at first you don't succeed, try writing your phone number on the exam paper.
Salem,
i implemented your example, the folowing code did indeed only not 100%. Puting the send function to whilie lus dose solves the problem with the buffer. But the problem is sends only when i kill the server, the client receivs the data only when the server is killd.
I also tryd with fflush function by implementing after whilie, but that did not helpt.
Last edited by Alix; 01-08-2012 at 02:26 PM.
How about reading beej, and practising the basics of opening a connection, sending some text and closing the connection again.
Your "diagnostic" makes no sense at all.
If you dance barefoot on the broken glass of undefined behaviour, you've got to expect the occasional cut.
If at first you don't succeed, try writing your phone number on the exam paper.
Has nothink to do with basic of opennin connection. i have no problem with connection, i can reaceive and send data true client and server thats no problem, i pass that part. Right now i have a problem with requesting a list of the server directory. Clients sends a command"list" and the server receives that command. When the server trys to send the list of directory to client, it stucks in the while loop, only when i kill the server it sends the entire list to client.
I think by putting the send method in while, that couses the problem. I wil try with malloc.
Thanks,
Alix
Getting stuck in the while() loop probably isn't going to be fixed by malloc, it's more likely a problem with your code to send and receive data. Post the relevant networking parts so we can see if it's correct.
i've found my problem, it was in the client side. I did not properly opend the socket connection on the client side and also not properly closed the socket connection.
I have on more question, i did'nt want it to open a new thread so i better ask here.
My question is how do i link newline"\n" to send function? Or do i have to add newline character at the readdir function? i tryd the folowing by adding '\n'
Code:DIR *dp; struct dirent *ep; dp = opendir ("./"); if (dp != NULL){ while (ep = readdir(dp)) rv = send(s, ep->d_name, strlen(ep->d_name), 0&'\n'); (void) closedir(dp); }else perror ("Couldn't open the directory"); close(s); stop_received = 1;
> rv = send(s, ep->d_name, strlen(ep->d_name), 0&'\n');
Just how little C do you know?
I mean, anyone who knew the basics would know this is such a non-starter.
Send a \n in another send call, or format a string and send that.
If you dance barefoot on the broken glass of undefined behaviour, you've got to expect the occasional cut.
If at first you don't succeed, try writing your phone number on the exam paper.
True i started a week a go with C programming. I did have tried to send "\n" in another send call. But it did not worked that's why i try something different:
Code:DIR *dp; struct dirent *ep; dp = opendir ("./"); char *newline="\n"; if (dp != NULL){ while (ep = readdir(dp)){ rv = send(s, ep->d_name, strlen(ep->d_name), 0); rv = send(s, newline, strlen(newline), 0); }(void) closedir(dp); }else perror ("Couldn't open the directory"); close(s); stop_received = 1;
