Factorial

[alireza beygi]

Hello Guys!
What's the problem with this simple code?!
Thanks.

#include <stdio.h>
#include <conio.h>
int main ()
{
    int n;
    int fact = 1;
    for (;;)
    {
        printf ("enter a number:\n");
        scanf ("%d", &n);
        for (int i = 1; i <= n; i++)
        fact *= i;
        printf ("Factorial is :%d\n", fact);
        }
    getch ();
    return 0;
}

[cauberong09]

Hello Guys!
What's the problem with this simple code?!
Thanks.

#include <stdio.h>
#include <conio.h>
int main ()
{
    int n;
    int fact = 1;
    for (;;)
    {
        printf ("enter a number:\n");
        scanf ("%d", &n);
        for (int i = 1; i <= n; i++)
        fact *= i;
        printf ("Factorial is :%d\n", fact);
        }
    getch ();
    return 0;
}

After each loop "for" value "fact" not restart to 1.In addtion,the loop will run forever.

[joybanerjee39]

Hello Guys!
What's the problem with this simple code?!
Thanks.

#include <stdio.h>
#include <conio.h>
int main ()
{
    int n;
    int fact = 1;
    for (;;)
    {
        printf ("enter a number:\n");
        scanf ("%d", &n);
        for (int i = 1; i <= n; i++)
        fact *= i;
        printf ("Factorial is :%d\n", fact);
        }
    getch ();
    return 0;
}

it has a infinite loop problem.
also, don't use <conio.h> and getch() , use getchar(); and <stdio.h> would suffice

[iMalc]

What's the problem with this simple code?!

The problem is that you're not checking the result of the scanf call, so if the user types in something non-numeric then n will be uninitialised and the loop will loop an unknown number of times.

If that's not the answer you were looking for then you need to explain the problem!