Thread: Segmentation fault (core dumped)

i cant figure out why this program i wrote this morning is giving me a seg fault
im also new here

Code:

#include<stdio.h>  #include<string.h>
#include<unistd.h>


//simple program that takes data and then prints it :-)


int main() {


int i;
int x;


struct input {


char input1[9];


};


struct input inputa;


puts("this program accepts alot of input from your keyboard,9 chars");


sleep(2);


printf("enter your first string value\n");
scanf("%s",inputa.input1);
printf("enter your second value\n");
scanf("%s",inputa.input1);
printf("enter your third value\n");
scanf("%s",inputa.input1);
printf("enter your fourth string value\n");
scanf("%s",inputa.input1);
printf("enter your fifth value\n");
scanf("%s",inputa.input1);
printf("enter your 6th value\n");
scanf("%s",inputa.input1);
printf("enter your 7th string value\n");
scanf("%s",inputa.input1);
printf("enter your 8th value\n");
scanf("%s",inputa.input1);
printf("enter your 9th value\n");
scanf("%s",inputa.input1);


sleep(2);






printf("now it will print out all the ........ you just typed above!\n");


for(x=0;x<9;x++)
   printf("%s\n\n",inputa.input1[x]);




printf(" DIDNT FEEL LIKE IT HAHAHAHAHAHAHAHA(JK)");


return(0);




}

In the following snippet:

Code:

struct input {
char input1[9];
};
 
struct input inputa;
...
for(x=0;x<9;x++)
   printf("%s\n\n",inputa.input1[x]);

You are telling printf to print a c-string but you are actually passing a single character.

Jim

Only the last thing typed will be saved, as your program is overwriting the same 9 bytes every time it accepts input.

You could fix this by having the struct be one of these three, and then fixing your input/output statements to match:

Code:

char input[9][xx]; /* xx is maximum string length */

char *input[9]; /* malloc() each one however long you want, fixed limit of 9 strings */

char **input; /* both number of strings and length of strings are dynamic */

per jimblumberg, the printf format %s wants an address, not a character. since you are passing a character, it will be used as an address and probably cause a segfault because it won't be valid.

i think im understanding now thank you

jimblumberg, then how do i make it print out the whole string instead of just a single character?

Something like:

Code:

printf("%s\n\n",inputa.input1);

Jim